Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding property to private_service_connect_ip_address to endpoint VectorSearchVectorStore #203

Merged
merged 16 commits into from May 21, 2024

Conversation

tdigangi
Copy link
Contributor

Add private_service_connect_ip_address to VectorSearchVectorStore via the from_components() method. Added placeholder integration test for private PSC endpoint.

Please provide guidance on how to update integration tests. Also if you wish to add more MatchingEngineIndexEndpoint properties in this PR or have a opinion on a more complex data structure(I.E. via kwargs or dict) to add properties provide this guidance and I will update accordingly.

…torStore via the from_components() method. Added placeholder integration test for private PSC endpoint.
@holtskinner
Copy link
Collaborator

/gcbrun

@lkuligin
Copy link
Collaborator

lkuligin commented May 2, 2024

@jzaldi PTAL

I'm actually wondering whether we need an integration test for that. Maybe a unit test that checks that we pass a parameter to the corresponding API call will be enough for the first step.

@tdigangi
Copy link
Contributor Author

tdigangi commented May 9, 2024

It looks like from_components is reliant upon a endpoint existing within the environment, thus I have put it in an integration test. I started to craft a unit test, but paused when I saw that endpoint requires an endpoints exists.

I believe it is an integration needed but this would have to be part of the infra setup used when these test execute. Let me know how you wish to proceed.

@gmogr
Copy link
Collaborator

gmogr commented May 14, 2024

/gcbrun

@tdigangi
Copy link
Contributor Author

I am unable to debug the cloud build error due to a lack of permission on the project in which they are placed. My best guess would be the endpoint is not set up with PSC.

@lkuligin
Copy link
Collaborator

@tdigangi I'm sorry for the delay, I'm looking for smbd from the Vertex Vector Store team to take a look and help with the review.

@lkuligin lkuligin merged commit d7bf728 into langchain-ai:main May 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants