ci: breaking change policy #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested in wjones127#3 |
westonpace
approved these changes
May 10, 2024
release_process.md
Outdated
| conventional commit markers: either exclamation mark after the type | ||
| (such as `feat!: change signature of func`) or have `BREAKING CHANGE` in the | ||
| body of the PR. A CI job will add a `breaking-change` label to the PR, which is | ||
| what will ultimately be used to CI to determine if the minor version should be |
There was a problem hiding this comment.
Suggested change
| what will ultimately be used to CI to determine if the minor version should be | |
| what will ultimately be used by CI to determine if the minor version should be |
Comment on lines
+83
to
+85
| * Upgrading a dependency pin that is in the Rust API. In particular, upgrading | ||
| `DataFusion` and `Arrow` are breaking changes. Changing dependencies that are | ||
| not exposed in our public API are not considered breaking changes. |
There was a problem hiding this comment.
Technically this is only true if we are upgrading from one major version to another. However, given that has been the case for most releases of arrow and datafusion, I'm not sure it needs to be called out.
There was a problem hiding this comment.
Depends on our definition of breaking change. For example if we change the pin from 40.0.0 to 40.0.1, and a user has pinned =40.0.0, we will have broken their build. But not really made a meaningful break change behavior wise I think.
| @@ -0,0 +1,63 @@ | |||
| """ | |||
albertlockett
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.