Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add priority to I/O scheduler #2315

Merged
merged 2 commits into from May 13, 2024

Conversation

westonpace
Copy link
Contributor

This also renames store scheduler to scan scheduler. I'm thinking I don't want to get into the thorny issue of how to prioritize I/O requests across different scans. So, with this approach, if multiple scans are running at the same time, then they will overschedule (and let the OS deal with it). This can be revisited in the future.

Closes #1958

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

Attention: Patch coverage is 76.70683% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 80.65%. Comparing base (ace9695) to head (14014ba).

Files Patch % Lines
rust/lance-io/src/testing.rs 12.50% 6 Missing and 22 partials ⚠️
rust/lance-io/src/scheduler.rs 92.68% 6 Missing and 3 partials ⚠️
rust/lance-encoding/src/lib.rs 0.00% 5 Missing ⚠️
...-encoding/src/encodings/logical/fixed_size_list.rs 0.00% 4 Missing ⚠️
rust/lance-encoding/src/encodings/logical/list.rs 81.81% 0 Missing and 4 partials ⚠️
rust/lance-file/src/v2/reader.rs 25.00% 1 Missing and 2 partials ⚠️
rust/lance-encoding/src/decoder.rs 50.00% 1 Missing and 1 partial ⚠️
...ust/lance-encoding/src/encodings/logical/struct.rs 88.88% 0 Missing and 2 partials ⚠️
...ust/lance-encoding/src/encodings/logical/binary.rs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2315      +/-   ##
==========================================
+ Coverage   80.62%   80.65%   +0.02%     
==========================================
  Files         191      192       +1     
  Lines       56447    56684     +237     
  Branches    56447    56684     +237     
==========================================
+ Hits        45509    45716     +207     
- Misses       8399     8404       +5     
- Partials     2539     2564      +25     
Flag Coverage Δ
unittests 80.65% <76.70%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems well designed. Nice work :)

@westonpace westonpace merged commit fe2d874 into lancedb:main May 13, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add priority to the I/O scheduler
3 participants