Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiplex SQ #2252

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

BubbleCal
Copy link
Contributor

@BubbleCal BubbleCal commented Apr 24, 2024

Benchmarking L2(uint8, scalar): Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 12.9s.
L2(uint8, scalar)       time:   [1.2831 s 1.2838 s 1.2845 s]
                        change: [-0.0534% +0.0802% +0.2032%] (p = 0.26 > 0.10)
                        No change in performance detected.

Benchmarking L2(uint8, w/o-scale: Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 12.7s.
L2(uint8, w/o-scale     time:   [1.2745 s 1.2755 s 1.2765 s]
                        change: [-0.0110% +0.1064% +0.2293%] (p = 0.11 > 0.10)
                        No change in performance detected.

this doesn't introduce significant performance reduction

Signed-off-by: BubbleCal <[email protected]>
Signed-off-by: BubbleCal <[email protected]>
Signed-off-by: BubbleCal <[email protected]>
Signed-off-by: BubbleCal <[email protected]>
Signed-off-by: BubbleCal <[email protected]>
Signed-off-by: BubbleCal <[email protected]>
Signed-off-by: BubbleCal <[email protected]>
Signed-off-by: BubbleCal <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.15044% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 80.78%. Comparing base (00cda83) to head (0a150b2).

Files Patch % Lines
rust/lance-index/src/vector/sq/storage.rs 55.00% 9 Missing ⚠️
rust/lance/src/index/vector/sq.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
- Coverage   80.80%   80.78%   -0.02%     
==========================================
  Files         192      192              
  Lines       56189    56223      +34     
  Branches    56189    56223      +34     
==========================================
+ Hits        45403    45422      +19     
- Misses       8117     8134      +17     
+ Partials     2669     2667       -2     
Flag Coverage Δ
unittests 80.78% <91.15%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BubbleCal BubbleCal added the donotmerge Do not merge label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
donotmerge Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants