Merge pull request #110 from froschdesign/hotfix/isfloat-emptystring

IsFloat validator should return a standard error message for empty strings
laminas · Nov 8, 2023 · dafb5ed · dafb5ed
2 parents 4f23433 + c42d9e5
commit dafb5ed
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/Validator/IsFloat.php b/src/Validator/IsFloat.php
@@ -118,6 +118,12 @@ public function isValid($value)
  return true;
  }
 
+ if ($value === '') {
+ $this->error(self::NOT_FLOAT);
+
+ return false;
+ }
+
  // Need to check if this is scientific formatted string. If not, switch to decimal.
  $formatter = new NumberFormatter($this->getLocale(), NumberFormatter::SCIENTIFIC);
 

diff --git a/test/Validator/IsFloatTest.php b/test/Validator/IsFloatTest.php
@@ -217,4 +217,14 @@ public function testNotFloat(): void
  $message = $this->validator->getMessages();
  self::assertStringContainsString('does not appear to be a float', $message['notFloat']);
  }
+
+ public function testEmptyStringShouldReturnStandardErrorMessage(): void
+ {
+ self::assertFalse($this->validator->isValid(''));
+ $message = $this->validator->getMessages();
+ self::assertStringContainsString(
+ 'does not appear to be a float',
+ $message['notFloat']
+ );
+ }
 }