now pylzy does not abort workflow in case of grpc error[WIP] #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtoLord
requested changes
Jul 6, 2023
Comment on lines
+46
to
+54
| self, | ||
| name: str, | ||
| owner: "Lzy", | ||
| env: Env, | ||
| provisioning: Provisioning, | ||
| auto_py_env: PyEnv, | ||
| *, | ||
| eager: bool = False, | ||
| interactive: bool = True |
| @@ -167,6 +171,8 @@ def __exit__(self, exc_type, exc_val, exc_tb) -> None: | |||
| finally: | |||
| if exc_type is None: | |||
| self.__destroy() | |||
| elif exc_type is AioRpcError: | |||
There was a problem hiding this comment.
Here may be UNAVAILABLE, so we must abort wf in this case
There was a problem hiding this comment.
UNAVAILABLE is retryable error. Python lzy-client should repeat request in case. If after an amount of attempts lzy service is still unavailable so I believe that it is really UNAVAILABLE and an abort request is useless :)
vhaldemar
requested changes
Jul 6, 2023
| @@ -145,6 +147,8 @@ def __enter__(self) -> "LzyWorkflow": | |||
| self.__snapshot = DefaultSnapshot(self.owner.serializer_registry, storage_uri, self.owner.storage_client, | |||
| self.owner.storage_name) | |||
| return self | |||
| except AioRpcError as e: | |||
There was a problem hiding this comment.
except AioRpcError:
raise
| @@ -167,6 +171,8 @@ def __exit__(self, exc_type, exc_val, exc_tb) -> None: | |||
| finally: | |||
| if exc_type is None: | |||
| self.__destroy() | |||
| elif exc_type is AioRpcError: | |||
There was a problem hiding this comment.
I think isinstance(e, AioRpcError) would be more accurate here
zhvkgj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.