Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

feat: use m and ~ like classic vim #153

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JW9506
Copy link

@JW9506 JW9506 commented Sep 15, 2020

This PR is for

  • Fix a reported issue : #XXX
  • Fix a unreported issue : Write summary in a new section
  • Add a reported feature implement : #XXX
  • Add a unreported feature implement : Write summary in a new section
  • Other : Write summary in a new section

Summary

Hi, spent some time to add marker feature that basic usage should work just fine.

Copy link
Owner

@lambdalisue lambdalisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Basically, I'm not maintaining this project anymore (#89) so I'm not sure if I merge it without approve from other reviewers (anyone?).

lib/jupyter/actions.js Outdated Show resolved Hide resolved
Copy link
Owner

@lambdalisue lambdalisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've requested some changes but anyway I need to wait for other reviewer reactions to merge this.

lib/jupyter/actions.js Outdated Show resolved Hide resolved
lib/jupyter/actions.js Outdated Show resolved Hide resolved
Copy link
Owner

@lambdalisue lambdalisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants