[wip] src/output.c: on config error restore outputs to previous state #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and notify clients about it Fixes: labwc#1525 Reported-by: @Tamaranch
Consolatis
force-pushed
the
fix/output_management_validate_commit
branch
from
0c661dd
to
d03af21
Compare
Consolatis
added a commit
to Consolatis/labwc
that referenced
this pull request
Feb 22, 2024
Preliminary fix for labwc#1525. Based on the protocol we should also revert all previously correctly committed outputs. labwc#1528 is doing just that but may cause regressions so we need a short term solution and then deal with potential issues in labwc#1528 after the release.
grisha128
pushed a commit
to grisha128/labwc
that referenced
this pull request
Apr 19, 2024
Preliminary fix for labwc#1525. Based on the protocol we should also revert all previously correctly committed outputs. labwc#1528 is doing just that but may cause regressions so we need a short term solution and then deal with potential issues in labwc#1528 after the release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and notify clients about it.
Fixes:
Reported-by: @Tamaranch