Refactor SSD: Move everything button related to src/ssd/ssd button.c
#1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Consolatis
force-pushed
the
refactor/ssd_button.c
branch
from
3802852
to
2ff6d23
Compare
Consolatis
commented
Aug 25, 2023
|
|
||
| struct ssd_rounded { | ||
| struct ssd_button *button; | ||
| struct wlr_scene_node *node; |
There was a problem hiding this comment.
s/node/rounded_buffer_node/
|
Hello, may I ask, what is left here for this to be ready to be merged? I'd be willing to work (and try to finish) this PR if I'd know what remains left to be done Thank you and have a nice day |
|
The main issue here is that we changed quite a lot in this area and this now needs to be rebased. It might be easier to start fresh using this PR as a mere template (e.g. which functions to move). There are further changes intended so we may want to wait a bit with the refactor to reduce further conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from
No functional changes intended
, will rebase once #1045 is merged.Edit:
This PR also adds a new node descriptor to the rounded button root tree node which has pointers for the rounded corner buffer and a
struct ssd_button. That allows to decouple the actual buttons (e.g.menuorclose) from the rounded corners which in turn allows for a future implementation oftitleLayout.