Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:grammatical errors #4483

Closed
wants to merge 1 commit into from
Closed

fix:grammatical errors #4483

wants to merge 1 commit into from

Conversation

bellingham07
Copy link

Grammatical errors

@bellingham07
fix:grammatical errors
668e882 
Grammatical errors
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Jan 13, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1145
✅ Successful 386
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 758
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Jan 13, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

@codecov Codecov
Copy link

codecov bot commented Jan 13, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.45%. Comparing base (ae7f63f) to head (668e882).
Report is 80 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4483   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bxy4543
Copy link
Member

bxy4543 commented Jan 15, 2024

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@bellingham07 Please sign the CLA

zzjin
zzjin reviewed Jan 17, 2024
View reviewed changes
controllers/account/controllers/account_controller.go
@@ -386,7 +386,7 @@ func (r *AccountReconciler) DeletePayment(ctx context.Context) error {
r.Logger.Error(err, "get payment handler failed")
return err
}
//delete payment if it is exist for more than 5 minutes
//delete payment if it is existed for more than 5 minutes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pr, but as gramma, maybe "if it exists for" is better.

zzjin
zzjin requested changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@zzjin zzjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK

@stale Stale
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically closed because we haven't heard back for more than 60 days, please reopen this issue if necessary.

@stale stale bot closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzjin zzjin zzjin requested changes

@bxy4543 bxy4543 bxy4543 approved these changes

Assignees
No one assigned
Labels
area/cloud response-expired size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bellingham07 @sealos-ci-robot @bxy4543 @zzjin