Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added English Version #170

Closed
wants to merge 2 commits into from
Closed

Added English Version #170

wants to merge 2 commits into from

Conversation

NextThread
Copy link

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Aug 13, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ NextThread
❌ maxdef89
You have signed the CLA already but the status is still pending? Let us recheck it.

@c121914yu
Copy link
Collaborator

Oh No, You cannot and should not add new files.

For hook files, you shou use useTranslation to translate.

import { useTranslation } from 'react-i18next';
...
const {t} = useTranslation()
....
t('....')

For no-hook files, You can only translate comments directly into English

@NextThread
Copy link
Author

NextThread commented Aug 17, 2023

@c121914yu yup, I'll close this PR and raising another one after integrating i18n

@NextThread NextThread closed this Aug 17, 2023
@NextThread
Copy link
Author

@c121914yu raised a new PR #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants