Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revive clone feature #2066

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: revive clone feature #2066

wants to merge 2 commits into from

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Nov 30, 2023

This PR revives "clone" feature which was commented out due to timing issue on large vfolder cloning ( > 10GB), which seems to be resolved already.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minimum required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Tests

  • You can see Cloneable icon for each vfolder in Cloneable column, for each row. (check icon will show up only when the vfolder is cloneable.)
  • You can change cloneable flag in "Update folder option", which can be triggered when you click "gear" icon in Control column.
  • When you try to clone vfolder which has more than 10GB size for total, It do take time but eventually cloning operation will be finished succesfully.

@lizable lizable self-assigned this Nov 30, 2023
@github-actions github-actions bot added the size:M 30~100 LoC label Nov 30, 2023
@lizable lizable marked this pull request as draft December 5, 2023 01:11
@lizable
Copy link
Contributor Author

lizable commented Dec 5, 2023

Since clone feature on backend part doesn't support cloning vfolders between different storages yet, therefore this PR will be on hold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant