Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: Hide unnecessary log snacker on service #1974

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

update: Hide unnecessary log snacker on service #1974

wants to merge 1 commit into from

Conversation

inureyes
Copy link
Member

@inureyes inureyes commented Oct 18, 2023 •
edited

🤖 Generated by Copilot at eaf7d2b

Summary

🙊🛡️🐛

Commented out some potentially unsafe or unnecessary code in backend-ai-painkiller.ts and lablup-notification.ts to improve error handling and security.

This PR resolves #1973

Walkthrough

  • Prevent potential XSS attacks by removing unnecessary innerHTML assignment (link)
  • Suppress error messages from being printed to the browser console in production mode by commenting out console.log statement (link)

@github-actions github-actions bot added the size:XS ~10 LoC label Oct 18, 2023
@inureyes inureyes added type:enhance Add new features effort:normal Need to understand a few modules / some extent of contextual or historical information. area:ux UI / UX issue. urgency:4 As soon as feasible, implementation is essential. platform:general impact:visible This change is visible to users. field:UI / UX urgency:5 It is imperative that action be taken right away. and removed urgency:4 As soon as feasible, implementation is essential. labels Oct 18, 2023
@inureyes inureyes added this to the 23.09 milestone Oct 18, 2023
@aws-amplify-ap-northeast-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1974.d3g9cs6u59b8lw.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@inureyes inureyes

Labels
area:ux UI / UX issue. effort:normal Need to understand a few modules / some extent of contextual or historical information. field:UI / UX impact:visible This change is visible to users. platform:general size:XS ~10 LoC type:enhance Add new features urgency:5 It is imperative that action be taken right away.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

Hide unnecessary log snacker on service
1 participant
@inureyes