Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add modifyEnd to insert, update and delete query builders #871

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

add modifyEnd to insert, update and delete query builders #871

wants to merge 12 commits into from
+308 −20

Conversation

thelinuxlich
Copy link

closes #835

@vercel Vercel
Copy link

vercel bot commented Feb 7, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 2:23pm

@thelinuxlich thelinuxlich mentioned this pull request Feb 10, 2024
Closed
igalklebanov
igalklebanov reviewed Apr 21, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
igalklebanov
igalklebanov reviewed Apr 21, 2024
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💪

This looks good and functional.

I think it should be simplified for now, and not straight up copied from select - select's case required a node, due to structured and unstructured modifiers, and as of late of.

@thelinuxlich thelinuxlich changed the title add modifyFront/modifyEnd to insert, update and delete query builders add modifyEnd to insert, update and delete query builders Apr 29, 2024
@igalklebanov
Copy link
Member

maybe we should add modifyEnd to MergeQueryBuilder as well.. but it's tricky (the split to multiple builders). I think anywhere .top(...) exists can also have a modifyEnd there.

@thelinuxlich
Copy link
Author

maybe we should add modifyEnd to MergeQueryBuilder as well.. but it's tricky (the split to multiple builders). I think anywhere .top(...) exists can also have a modifyEnd there.

Done!

@igalklebanov igalklebanov added enhancement New feature or request api Related to library's API labels Apr 30, 2024
igalklebanov
igalklebanov approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalklebanov igalklebanov igalklebanov approved these changes

Assignees
No one assigned
Labels
api Related to library's API enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add modifyFront/modifyEnd to all queryBuilder classes
2 participants
@thelinuxlich @igalklebanov