Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for breakpoints and external debugger #27

Merged
merged 43 commits into from
May 26, 2024
Merged

feat: add support for breakpoints and external debugger #27

merged 43 commits into from
May 26, 2024

Conversation

kxxt
Copy link
Owner

@kxxt kxxt commented May 22, 2024 •
edited

Close #14

TODO

  • Implement TUI for managing breakpoints.
  • Implement TUI for managing breakpoint hit events.
    • Add support for editing external cmdline in TUI and setting it in CLI
  • Add support for launching external debugger.
  • Setting tracer delay from CLI.
  • Add support for more kinds of patterns.
  • Error dialog for detach/kill/resume errors.
  • Add help for hit manager
  • Update README and add a gif.

Enhancements (Maybe implement in the future?)

  • Set breakpoint from CLI
  • One-time breakpoint.

@kxxt kxxt added enhancement New feature or request priority-high tui TUI tracer Core tracer component difficulty-hard labels May 22, 2024
@kxxt kxxt added this to the 0.4 milestone May 22, 2024
@kxxt kxxt self-assigned this May 22, 2024
@kxxt kxxt force-pushed the feat/debugger-launcher branch 3 times, most recently from 7107f55 to 3c1012d Compare May 22, 2024 15:14
@kxxt kxxt force-pushed the feat/debugger-launcher branch 2 times, most recently from 48d2b5e to d43dc2f Compare May 23, 2024 01:11
@kxxt kxxt force-pushed the feat/debugger-launcher branch 4 times, most recently from e540ce4 to 2cccb77 Compare May 24, 2024 13:43
kxxt added 23 commits May 26, 2024 20:00
@kxxt
tui: move cursor to end when editing existing breakpoint
bf022b2
@kxxt
feat/tui: cancel editing using Ctrl+C
9fd9e8b
@kxxt
tui: also use e key for editing breakpoint
c12c438
@kxxt
chore: make clippy happy
8aafcc2
@kxxt
feat: add warn about seccomp-bpf
84a22c7
@kxxt
tui: remove suspend seccomp-bpf
c0ddfb1 
It doesn't work. The seccomp-bpf filter get re-enabled after detach, which is not mentioned in the man pages.
@kxxt
feat: implement a regex cursor for space joined argv
4773a84
@kxxt
feat: add support for other kinds of breakpoint patterns
3dfcf60
@kxxt
feat/tui: add info popup
088c56c
@kxxt
feat/tui: add help for breakpoint manager
50159b8
@kxxt
tui: add new process status to f1 help
eca29bd
@kxxt
feat: set default external command from cli
d470caf
@kxxt
feat/tui: add editor for default command in hit manager
1301589
@kxxt
feat/tui: add support for custom one-time command
5d67c6b
@kxxt
feat: add breakpoints from CLI
9695582
@kxxt
fix: propagate detach/resume errors to TUI
1e4e97c
@kxxt
fix: don't crash if external command fail
ccfa42a
@kxxt
feat/tui: show breakpoint pattern in hit manager
f4cd976
@kxxt
fix: make sure command is not empty or whitespace
64eca70
@kxxt
fix/tui: hide hit_manager when switching pane
6b3630e
@kxxt
feat/tui: add help for hit manager
39d31b2
@kxxt
fix/tui: fix off-by-one in hit-manager
4b7d9ca
@kxxt
docs: add an example about launching debuggers
e132195
@kxxt kxxt marked this pull request as ready for review May 26, 2024 13:38
@kxxt kxxt merged commit 3309c3c into main May 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kxxt kxxt

Labels
difficulty-hard enhancement New feature or request priority-high tracer Core tracer component tui TUI
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.

[Feature] allow external debugger to attach
1 participant
@kxxt