Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add acceptable tag ruby and rt #434

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

add acceptable tag ruby and rt #434

wants to merge 2 commits into from

Conversation

dokosho02
Copy link

I tested locally and found that it does indeed preserve the ruby and rt tags, so I submitted a pull request.

kurtmckee
kurtmckee requested changes Mar 18, 2024
View reviewed changes
Copy link
Owner

@kurtmckee kurtmckee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I anticipate that this should also support the <rp> element, for user agents that cannot render ruby elements.

feedparser/sanitizer.py
@@ -108,6 +108,8 @@ class HTMLSanitizer(BaseHTMLProcessor):
"pre",
"progress",
"q",
"rt",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"rt",
"rp",
"rt",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtmckee kurtmckee kurtmckee requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dokosho02 @kurtmckee