Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types for ts #28

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

johannbuscail
Copy link

This pull request adds typing to secure-env as requested in #23
I added a small test, resolved some errors and updated the documentation.
I changed some property names to make it more clear and easy to maintain.

To add types, it's easy, just use generics:

import SecureEnv, { IObject } from "secure-env"

interface IEnv extends IObject{
  DB_HOST: string;
  DB_USER: string;
  DB_PASS: string;
}

const env = SecureEnv<IEnv>(your_options);

If there's anything I can improve, just tell me :)
That's all, I hope it will be merged quickly !

@kunalpanchal
Copy link
Owner

Thank you for the PR @johannb75. Looks neat. I will review the PR at the earliest.

@johannbuscail
Copy link
Author

Hello @kunalpanchal, do you know when this will be merged and published ?

@johannbuscail
Copy link
Author

@kunalpanchal could you merge it and publish it to npm ??

@johannbuscail
Copy link
Author

@kunalpanchal any update ?
The work is already done. You only have to merge it and publish it.

@vishnu-blkbox
Copy link

@kunalpanchal can you merge this if this is ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants