Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer): allow transforming of .cts/.mts extensions. (#3996) #4002

Merged
merged 1 commit into from
May 28, 2024

Conversation

smack0007
Copy link
Contributor

@smack0007 smack0007 commented Jan 26, 2023

Summary

This is a pull request to implement the feature request:
Support loading of ".cjs" and ".cts" files. #3996
Closes #3996

Test plan

I added 2 test cases to src/legacy/ts-jest-transformer.spec.ts to test loading of '.cts' and '.cjs' files.

npm run test reports:

Test Suites: 35 passed, 35 total
Tests:       329 passed, 329 total
Snapshots:   135 passed, 135 total

npm run test-examples also exited successfully.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This fix will allow us to remove our hack we've been using in order to transform .cts files and load .cjs files.

@muuvmuuv
Copy link

Hey, thanks for the work! I do get these errors as well now in Angular. Can you have a look at failing tests and update your branch to latest?

Is there anything else needed for this PR to get merged?

Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ahnpnl ahnpnl merged commit b8f6eaa into kulshekhar:main May 28, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support loading of ".cjs" and ".cts" files.
3 participants