-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest envsubst #329
base: main
Are you sure you want to change the base?
manifest envsubst #329
Conversation
b54e503
to
00a12fe
Compare
af907cc
to
a63763d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a deeper look later today... however I would move out of test/utils
. It was there prior to my getting involved but have always disliked it. We don't use "utils" in Go generally. the package name provides meaning and context to the use of a func or struct. Could we please consider moving it to a more meaningful package?
We are not going to introduce a need copyright into our code base tho... so translate.go needs to change to a deps or be written.
Thanks for the contribution... We need a sign-off on the DCO to move forward |
thanks @so-jelly for this contrib! It would very much helm me with asserting cluster-wide resources dynamically instanciated by a kuttl and referencing the associated $NAMESPACE. Any chance for you to proceed with the DCO signature so that this feature can be merged,, such as running |
@so-jelly can you rebase and add DCO - happy to see this change comes in ;) |
Signed-off-by: Shawn O'Dell <[email protected]>
ef0ff92
to
5a4ea3e
Compare
Co-authored-by: Chris Bandy <[email protected]> Signed-off-by: Shawn O'Dell <[email protected]>
Signed-off-by: Shawn O'Dell <[email protected]>
Signed-off-by: Shawn O'Dell <[email protected]>
Co-authored-by: Chris Bandy <[email protected]> Signed-off-by: Shawn O'Dell <[email protected]>
Co-authored-by: Chris Bandy <[email protected]> Signed-off-by: Shawn O'Dell <[email protected]>
5a4ea3e
to
68ecec1
Compare
Signed-off-by: Shawn O'Dell <[email protected]>
ba9ac47
to
1f4be62
Compare
I refactored to remove that licensed code. Some edge cases i considered is variables in GVK and keys. I have thought through this a bit and I think it is sound. I can add some test cases as well. |
Signed-off-by: Shawn O'Dell <[email protected]>
I created test cases for some additional field entries. I am not sure what is up with Github review requests. tagging @kensipe in case the review request isn't sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this basically yesterday :) Any chance we can see this merged?
Signed-off-by: Shawn O'Dell <[email protected]>
5672807
to
fb20595
Compare
@jaypipes I can provide details elsewhere... I'm just seeing this. looks urgent and apologies for being out of pocket... for way too long. I will review today/night and respond and/or merge |
What this PR does / why we need it:
This PR replaces variable references in manifests with environment variables. It also adds the generated pet name to the environment so that it can be templated as well.
Fixes # #203