Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: refactor the cue engine with cuex #162

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Apr 24, 2023

Description of your changes

Chore: refactor the cue engine with cuex

TODO:

  • refactor config provider and add it to cuex.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Attention: Patch coverage is 19.73039% with 655 lines in your changes are missing coverage. Please review.

Project coverage is 21.58%. Comparing base (f187b42) to head (45b2929).

Files Patch % Lines
pkg/providers/legacy/kube/kube.go 5.59% 135 Missing ⚠️
pkg/providers/legacy/metrics/prom_check.go 3.26% 89 Missing ⚠️
pkg/providers/legacy/http/http.go 4.39% 87 Missing ⚠️
pkg/providers/legacy/workspace/workspace.go 14.08% 61 Missing ⚠️
pkg/providers/legacy/util/util.go 8.33% 55 Missing ⚠️
pkg/tasks/custom/action.go 14.06% 55 Missing ⚠️
pkg/providers/legacy/email/email.go 8.10% 34 Missing ⚠️
pkg/tasks/custom/task.go 36.00% 27 Missing and 5 partials ⚠️
pkg/cue/model/value/value.go 39.02% 24 Missing and 1 partial ⚠️
pkg/providers/legacy/time/time.go 16.66% 20 Missing ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #162       +/-   ##
===========================================
- Coverage   66.76%   21.58%   -45.19%     
===========================================
  Files          50       52        +2     
  Lines        4553     3572      -981     
===========================================
- Hits         3040      771     -2269     
- Misses       1108     2644     +1536     
+ Partials      405      157      -248     
Flag Coverage Δ
e2etests 21.58% <19.73%> (-0.56%) ⬇️
unit-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

controllers/testdata/test-apply.yaml Show resolved Hide resolved
pkg/executor/workflow.go Outdated Show resolved Hide resolved
pkg/generator/generator.go Outdated Show resolved Hide resolved
@FogDong FogDong force-pushed the feat-cuex branch 2 times, most recently from 63f9400 to 52a8c9a Compare April 25, 2023 03:47
Copy link
Contributor

@Somefive Somefive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Generally LGTM. Let's make a sync PR in the kubevela/kubevela and see if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants