Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] add a note in Japanese Localization README #46421

Merged

Conversation

Okabe-Junya
Copy link
Member

Change List

  • add a note in Japanese Localization README
    • カッコの前後にスペースを含めるか否かを議論したのでl10nのREADMEに明記する

ref. https://kubernetes.slack.com/archives/CAG2M83S8/p1715772425079079?thread_ts=1715762463.184719&cid=CAG2M83S8

一応確認ですが、カッコの前後は一律でスペースを含めないということでおけでしょうか?

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label May 17, 2024
@k8s-ci-robot k8s-ci-robot requested a review from kakts May 17, 2024 10:20
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2024
@Okabe-Junya
Copy link
Member Author

/assign nasa9084

Copy link

netlify bot commented May 17, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 083be57
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66472f73aa559d00082b51fa
😎 Deploy Preview https://deploy-preview-46421--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Okabe-Junya
Copy link
Member Author

@inductor
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2024
@nasa9084
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9962b30564767421f4fda0c5b1732b27b32f3d16

@k8s-ci-robot k8s-ci-robot merged commit 564844b into kubernetes:main May 27, 2024
6 checks passed
@Okabe-Junya Okabe-Junya deleted the update-japanese-localization branch May 27, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants