Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up go mod #18666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

clean up go mod #18666

wants to merge 1 commit into from
+2 −4

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Apr 17, 2024

trying to remove two replaces that might not be needed anymore

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 17, 2024
@medyagh
Copy link
Member Author

medyagh commented Apr 17, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
afbjorklund
afbjorklund requested changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@afbjorklund afbjorklund left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't revert the cpuid renaming that was done previously.

If it needs to be done, it should go in minikube-machine properly...

https://github.com/minikube-machine/machine/blob/main/drivers/virtualbox/vtx_intel.go

@medyagh
Copy link
Member Author

medyagh commented Apr 17, 2024

Please don't revert the cpuid renaming that was done previously.

If it needs to be done, it should go in minikube-machine properly...

https://github.com/minikube-machine/machine/blob/main/drivers/virtualbox/vtx_intel.go

good call thank you, yes I rather get rid of as many replaces as I can :) I will do that on minikube-machine fist then

@medyagh
Copy link
Member Author

medyagh commented Apr 17, 2024

made a PR minikube-machine/machine#5

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18666) |
+----------------+----------+---------------------+
| minikube start | 51.5s    | 52.6s               |
| enable ingress | 25.8s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube start: 53.2s 51.9s 51.8s 50.9s 49.9s
Times for minikube (PR 18666) start: 53.7s 54.9s 51.7s 51.0s 51.6s

Times for minikube ingress: 27.0s 27.5s 25.0s 25.0s 24.5s
Times for minikube (PR 18666) ingress: 27.5s 25.0s 28.0s 27.6s 27.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18666) |
+----------------+----------+---------------------+
| minikube start | 22.8s    | 23.0s               |
| enable ingress | 21.3s    | 21.5s               |
+----------------+----------+---------------------+

Times for minikube start: 20.9s 21.2s 24.2s 24.0s 23.5s
Times for minikube (PR 18666) start: 23.5s 23.7s 21.4s 22.0s 24.4s

Times for minikube ingress: 21.3s 21.3s 21.2s 21.3s 21.3s
Times for minikube (PR 18666) ingress: 21.3s 21.2s 21.3s 22.3s 21.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18666) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 21.4s               |
| enable ingress | 32.1s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 19.7s 30.7s 46.7s 31.8s 31.8s
Times for minikube (PR 18666) ingress: 31.8s 31.7s 31.8s 31.8s 31.7s

Times for minikube start: 22.2s 20.5s 22.4s 20.2s 22.4s
Times for minikube (PR 18666) start: 19.6s 20.9s 22.5s 23.2s 20.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 4.65 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 5.56 (chart)
QEMU_macOS TestErrorSpam/setup (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/CertSync (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/DashboardCmd (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/NodeLabels (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/SSHCmd (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/StatusCmd (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 5.88 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh mentioned this pull request May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund requested changes

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@medyagh @k8s-ci-robot @minikube-pr-bot @afbjorklund