Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15835
Make
MINIKUBE_HOME
env variable usage more convenient with backward compatibility.Current logic of
MINIKUBE_HOME
env usage isn't really obvious:${HOME}/.minikube
as default..minikube
- use env var.minikube
to env var value (for some reason??)It's very implicit logic and goes against the conventional use of
*_HOME
env vars.With this changes, the logic changes a bit:
${HOME}/.minikube
as default (as it's now).minikube
- use env var (as it's now).minikube
inside path, provided via env var (for backward compatibility)${MINIKUBE_HOME}/.minikube
exists - use this legacy path (for backward compatibility)MINIKUBE_HOME
as is (new)So, here is example cases:
.minikube
:.minikube
AND there is NO.minikube
inside:.minikube
AND there is.minikube
inside provided path: