Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ut] increase covrage for kubelet/prober/results #116931

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[ut] increase covrage for kubelet/prober/results #116931

merged 1 commit into from
Oct 31, 2023

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Mar 26, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Increase covrage for kubelet/prober/results

before:

        k8s.io/kubernetes/pkg/kubelet/prober/results    coverage: 69.2% of statements

after this change:

        k8s.io/kubernetes/pkg/kubelet/prober/results    coverage: 100.0% of statements

Which issue(s) this PR fixes:

Part of #109717

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 26, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.27 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.27.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Mar 26 10:24:24 UTC 2023.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 26, 2023
@my-git9
Copy link
Member Author

my-git9 commented Mar 26, 2023

/test pull-kubernetes-unit

@bart0sh
Copy link
Contributor

bart0sh commented Mar 30, 2023

/triage accepted
/priority important-longterm
/assign

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 30, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Mar 30, 2023
@my-git9 my-git9 requested a review from bart0sh March 31, 2023 10:07
@my-git9
Copy link
Member Author

my-git9 commented Mar 31, 2023

/test pull-kubernetes-conformance-kind-ga-only-parallel

@my-git9 my-git9 requested a review from bart0sh April 1, 2023 07:07
bart0sh
bart0sh reviewed Apr 1, 2023
View reviewed changes
pkg/kubelet/prober/results/results_manager_test.go Outdated
}{
{
name: "result is Success",
result: 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use constants instead of their values here ? e.g. result: Success

@my-git9 my-git9 force-pushed the CreateListener-ut branch 2 times, most recently from 3df45c4 to 70b1a86 Compare April 2, 2023 10:53
@my-git9
Copy link
Member Author

my-git9 commented Apr 2, 2023

/test pull-kubernetes-e2e-gce

@my-git9
Copy link
Member Author

my-git9 commented Apr 2, 2023

/test pull-kubernetes-unit

@bart0sh
Copy link
Contributor

bart0sh commented Apr 2, 2023

/retest

@bart0sh
Copy link
Contributor

bart0sh commented Apr 2, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 784f5527fd8499269b38f6ac4dfc6a69f584bb43

@bart0sh bart0sh moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Apr 2, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Apr 2, 2023

/assign @mrunalp @SergeyKanzhelev @derekwaynecarr @dchen1107

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, my-git9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit af18989 into kubernetes:master Oct 31, 2023
11 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Oct 31, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh bart0sh left review comments

@mrunalp mrunalp mrunalp approved these changes

@bobbypage bobbypage Awaiting requested review from bobbypage

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@mrunalp mrunalp

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@my-git9 @k8s-ci-robot @bart0sh @k8s-triage-robot @mrunalp @derekwaynecarr @dchen1107 @SergeyKanzhelev