Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some unit tests in the belly of the kubelet #111041

Closed
wants to merge 52 commits into from
Closed

Add some unit tests in the belly of the kubelet #111041

wants to merge 52 commits into from

Conversation

fire833
Copy link

@fire833 fire833 commented Jul 9, 2022

This PR doesn't add too much, but I found a few methods that didn't have unit tests in the kubelet area of the code, so I figured I would add some.

This PR is still a WIP, will add to a few stub tests that I added soon.

What type of PR is this?

/kind unit-test
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Work for #109717

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 9, 2022
@k8s-ci-robot
Copy link
Contributor

@fire833: The label(s) kind/unit-test cannot be applied, because the repository doesn't have them.

In response to this:

This PR doesn't add too much, but I found a few methods that didn't have unit tests in the kubelet area of the code, so I figured I would add some.

This PR is still a WIP, will add to a few stub tests that I added soon.

What type of PR is this?

/kind unit-test
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Work for #109717

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 9, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @fire833!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @fire833. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 9, 2022
s-kawamura-w664
s-kawamura-w664 reviewed Jul 13, 2022
View reviewed changes
Copy link

@s-kawamura-w664 s-kawamura-w664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR still WIP?
Let me make one comment, because the test fails in my envrionment.

pkg/kubelet/cm/helpers_linux_test.go Outdated Show resolved Hide resolved
@fire833
Copy link
Author

fire833 commented Jul 15, 2022

Is this PR still WIP? Let me make one comment, because the test fails in my envrionment.

It is not, I am done with this one. I updated that test case.

@s-kawamura-w664
Copy link

@fire833
Thank you for update. It is fine.
Can you use git rebase to delete the label do-not-merge/contains-merge-commits.
The detail is here: #111041 (comment).

Abirdcfly and others added 10 commits July 26, 2022 21:04
@Abirdcfly @fire833
Update golangci-lint to 1.46.2 and fix errors
062c8da 
Signed-off-by: Abirdcfly <[email protected]>
@fire833
WIP: Added unit tests for parsePercentage and other methods in
7560e3e 
container_manager.go for kubelet.

Signed-off-by: fire833 <[email protected]>
@fire833
Added another test with linux_helpers.
8ac8b3a 
Signed-off-by: fire833 <[email protected]>
@chendave @fire833
kubeadm: Don't ask for input if it's dry run mode
2aafc5f 
Signed-off-by: Dave Chen <[email protected]>
@thockin @fire833
Rename IPFamilyPolicyType => IPFamilyPolicy
728a546
@heyste @fire833
Create e2e test for ResourceQuota endpoints
7b1ad4d 
e2e test validates the following 3 extra endpoints
- deleteCoreV1CollectionNamespacedResourceQuota
- listCoreV1ResourceQuotaForAllNamespaces
- patchCoreV1NamespacedResourceQuota
@heyste @fire833
Create APIService lifecycle e2e test
1d02da8 
The test validates the following endpoints
- deleteApiregistrationV1CollectionAPIService
- patchApiregistrationV1APIServiceStatus
- replaceApiregistrationV1APIService
- replaceApiregistrationV1APIServiceStatus
@mengjiao-liu @fire833
Update godoc.org to pkg.go.dev in kubeadm
b021c7d
@mpuckett159 @fire833
Add cases for when --timeout=0 and tests
e072f81
@SataQiu @fire833
scheduler: do not update sched.nextStartNodeIndex when evaluate nomin…
4ccf3e3 
…ated node
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/conformance Issues or PRs related to kubernetes conformance tests area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/kubectl area/network-policy Issues or PRs related to Network Policy subproject area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Aug 5, 2022
@fire833 fire833 closed this Aug 5, 2022
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-kawamura-w664 s-kawamura-w664 s-kawamura-w664 left review comments

@krmayankk krmayankk Awaiting requested review from krmayankk

@sjenning sjenning Awaiting requested review from sjenning

Assignees
No one assigned
Labels
area/apiserver area/cloudprovider area/code-generation area/conformance Issues or PRs related to kubernetes conformance tests area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/kubectl area/kubelet area/network-policy Issues or PRs related to Network Policy subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet