Add unittest for k/k/pkg/kubelet/cm/cgroup_manager_linux.go #110193

zabrox · 2022-05-24T13:39:50Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR adds tests to k/k/pkg/kubelet/cm/cgroup_manager_linux.go.

Add test for cgroupManagerImpl.Name
Add test for IsSystemdStyleName
Append test case for TestParseSystemdToCgroupName

Which issue(s) this PR fixes:

Fix part of #109717

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

linux-foundation-easycla · 2022-05-24T13:39:53Z

The committers listed above are authorized under a signed CLA.

✅ login: zabrox / name: K. Takase (28eb3b8, 2e78203, 91f6ac5)

k8s-ci-robot · 2022-05-24T13:39:57Z

Welcome @zabrox!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-05-24T13:39:58Z

Hi @zabrox. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zabrox · 2022-05-25T10:33:36Z

/easycla

zabrox · 2022-05-25T10:37:35Z

/easycla

yangjunmyfm192085

/ok-to-test

zabrox · 2022-05-25T16:26:24Z

/retest

pacoxu · 2022-05-26T03:51:45Z

/label tide/merge-method-squash

zabrox · 2022-05-26T05:09:59Z

@pacoxu
Thank you for your comment.
I've modified the description.

zabrox · 2022-05-28T06:16:11Z

@yangjunmyfm192085 @pacoxu
I want this PR to be approved.
I am new to k8s contribution. Is there something I have to do?

yangjunmyfm192085

/cc @pacoxu
/triage accepted

pacoxu · 2022-05-30T02:39:15Z

/triage accepted
/priority backlog

pacoxu · 2022-05-30T07:10:18Z

/lgtm

zabrox · 2022-05-30T15:18:17Z

/assign @Random-Liu

mrunalp · 2022-06-27T23:52:33Z

pkg/kubelet/cm/cgroup_manager_linux_test.go

@@ -169,3 +173,63 @@ func TestParseSystemdToCgroupName(t *testing.T) {
 }
 }
 }
+
+func TestName(t *testing.T) {


TestCgroupName

@mrunalp
This test is for cgroupManagerImpl.Test, not for CgroupTest.

Can we make the it more descriptive? TestName is too generic.

Changed test name to TestCgroupManagerName.

k8s-ci-robot · 2022-06-29T14:29:39Z

New changes are detected. LGTM label has been removed.

k8s-ci-robot · 2022-06-29T14:30:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zabrox
To complete the pull request process, please ask for approval from random-liu after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

pkg/kubelet/cm/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pacoxu · 2022-07-01T02:15:48Z

/lgtm

k8s-triage-robot · 2022-09-29T02:58:32Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-10-29T03:12:01Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2022-11-28T03:42:05Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2022-11-28T03:42:10Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 24, 2022

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 24, 2022

k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 24, 2022

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 24, 2022

k8s-ci-robot requested review from pacoxu and yujuhong May 24, 2022 13:40

k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 24, 2022

zabrox added 3 commits May 25, 2022 19:56

Add test for cgroupManagerImpl.Name

28eb3b8

Add testcase to TestParseSystemdToCgroupName

2e78203

Add test for IsSystemdStyleName

91f6ac5

zabrox force-pushed the 109717 branch from 15e0da8 to 91f6ac5 Compare May 25, 2022 10:57

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 25, 2022

yangjunmyfm192085 reviewed May 25, 2022

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2022

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 26, 2022

SergeyKanzhelev added this to Triage in SIG Node PR Triage May 27, 2022

yangjunmyfm192085 reviewed May 28, 2022

View reviewed changes

pacoxu moved this from Triage to Needs Approver in SIG Node PR Triage May 30, 2022

k8s-ci-robot assigned pacoxu May 30, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2022

k8s-ci-robot assigned Random-Liu May 30, 2022

mrunalp reviewed Jun 27, 2022

View reviewed changes

Modified test function name

1f723d2

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 29, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 29, 2022

k8s-ci-robot closed this Nov 28, 2022

SIG Node PR Triage automation moved this from Needs Approver to Done Nov 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unittest for k/k/pkg/kubelet/cm/cgroup_manager_linux.go #110193

Add unittest for k/k/pkg/kubelet/cm/cgroup_manager_linux.go #110193

zabrox commented May 24, 2022 •

edited

linux-foundation-easycla bot commented May 24, 2022 •

edited

k8s-ci-robot commented May 24, 2022

k8s-ci-robot commented May 24, 2022

zabrox commented May 25, 2022

zabrox commented May 25, 2022

yangjunmyfm192085 left a comment

zabrox commented May 25, 2022

pacoxu commented May 26, 2022

zabrox commented May 26, 2022

zabrox commented May 28, 2022

yangjunmyfm192085 left a comment •

edited

pacoxu commented May 30, 2022

pacoxu commented May 30, 2022

zabrox commented May 30, 2022

mrunalp Jun 27, 2022

zabrox Jun 28, 2022

mrunalp Jun 28, 2022

zabrox Jun 29, 2022

k8s-ci-robot commented Jun 29, 2022

k8s-ci-robot commented Jun 29, 2022

pacoxu commented Jul 1, 2022

k8s-triage-robot commented Sep 29, 2022

k8s-triage-robot commented Oct 29, 2022

k8s-triage-robot commented Nov 28, 2022

k8s-ci-robot commented Nov 28, 2022

Add unittest for k/k/pkg/kubelet/cm/cgroup_manager_linux.go #110193

Add unittest for k/k/pkg/kubelet/cm/cgroup_manager_linux.go #110193

Conversation

zabrox commented May 24, 2022 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

linux-foundation-easycla bot commented May 24, 2022 • edited

k8s-ci-robot commented May 24, 2022

k8s-ci-robot commented May 24, 2022

zabrox commented May 25, 2022

zabrox commented May 25, 2022

yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

zabrox commented May 25, 2022

pacoxu commented May 26, 2022

zabrox commented May 26, 2022

zabrox commented May 28, 2022

yangjunmyfm192085 left a comment • edited

Choose a reason for hiding this comment

pacoxu commented May 30, 2022

pacoxu commented May 30, 2022

zabrox commented May 30, 2022

mrunalp Jun 27, 2022

Choose a reason for hiding this comment

zabrox Jun 28, 2022

Choose a reason for hiding this comment

mrunalp Jun 28, 2022

Choose a reason for hiding this comment

zabrox Jun 29, 2022

Choose a reason for hiding this comment

k8s-ci-robot commented Jun 29, 2022

k8s-ci-robot commented Jun 29, 2022

pacoxu commented Jul 1, 2022

k8s-triage-robot commented Sep 29, 2022

k8s-triage-robot commented Oct 29, 2022

k8s-triage-robot commented Nov 28, 2022

k8s-ci-robot commented Nov 28, 2022

zabrox commented May 24, 2022 •

edited

linux-foundation-easycla bot commented May 24, 2022 •

edited

yangjunmyfm192085 left a comment •

edited