Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Platform Deps in cmd/kubelet/options #103870

Closed
wants to merge 5 commits into from

Conversation

pmgk07
Copy link

@pmgk07 pmgk07 commented Jul 23, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Refactor platform dependencies in cmd/kubelet/options package. Improves code manageability & readability

Which issue(s) this PR fixes:

Part of #60338

Additional note to the reviewers

Keeping this in WIP mainly to see how the CI/CD reacts

Does this PR introduce a user-facing change?

NONE

Refactor platform dependencies of kubelet options
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

@pmgk07: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @pmgk07!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @pmgk07. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pmgk07
To complete the pull request process, please assign sjenning after the PR has been reviewed.
You can assign the PR to them by writing /assign @sjenning in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 23, 2021
@pmgk07 pmgk07 changed the title WIP: Refactor Platform Deps WIP: Refactor Platform Deps in cmd/kubelet/options Jul 23, 2021
@pmgk07 pmgk07 changed the title WIP: Refactor Platform Deps in cmd/kubelet/options Refactor Platform Deps in cmd/kubelet/options Jul 26, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Aug 2, 2021
@ehashman
Copy link
Member

ehashman commented Aug 2, 2021

Thank you for your PR. It seems to only contain trivial edits. Please read our trivial edits policy. We encourage you to take a look at confirmed issues and bugs or issues marked help-wanted.

In particular, this PR is refactoring docker-specific code, but we are currently in the process of deprecating Dockershim, so I don't think it makes much sense to take these changes.

/close

@k8s-ci-robot
Copy link
Contributor

@ehashman: Closed this PR.

In response to this:

Thank you for your PR. It seems to only contain trivial edits. Please read our trivial edits policy. We encourage you to take a look at confirmed issues and bugs or issues marked help-wanted.

In particular, this PR is refactoring docker-specific code, but we are currently in the process of deprecating Dockershim, so I don't think it makes much sense to take these changes.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Node PR Triage automation moved this from Triage to Done Aug 2, 2021
@pmgk07 pmgk07 deleted the refactor-platform-deps branch February 12, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants