-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Platform Deps in cmd/kubelet/options #103870
Conversation
Refactor platform dependencies of kubelet options
@pmgk07: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @pmgk07! |
Hi @pmgk07. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pmgk07 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…fic file instead of the entire function
Thank you for your PR. It seems to only contain trivial edits. Please read our trivial edits policy. We encourage you to take a look at confirmed issues and bugs or issues marked In particular, this PR is refactoring docker-specific code, but we are currently in the process of deprecating Dockershim, so I don't think it makes much sense to take these changes. /close |
@ehashman: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Refactor platform dependencies in cmd/kubelet/options package. Improves code manageability & readability
Which issue(s) this PR fixes:
Part of #60338
Additional note to the reviewers
Keeping this in WIP mainly to see how the CI/CD reacts
Does this PR introduce a user-facing change?