Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: automate release workflow #2325

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: automate release workflow #2325

wants to merge 3 commits into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Feb 19, 2024 •
edited

Blocked by (and rebased on) #2316 and #2324. Please merge them first, preferably in that order.

Test run: rexagod#9.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2024
@rexagod rexagod mentioned this pull request Feb 20, 2024
Closed
@rexagod rexagod force-pushed the automate-release branch 4 times, most recently from 82f71d3 to 122cee8 Compare February 21, 2024 07:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 21, 2024
@rexagod
chore: lint README.md
a3a277d 
To primarily avoid conflicts and allow for automations.

Signed-off-by: Pranshu Srivastava <[email protected]>
@rexagod
Update VERSION to reflect the latest patch release
e1ef74e 
Reflect patch release changes on main, which was not the case with
2.10.1 since that diverged and was never merged back into main (around
backporting concerns).

I believe in the future we can merge everything
back into main to reflect the latest version changes in main, but
diverge the release branches starting from the pre-merge commit to make
sure backports are clean and maintainable (these will not be merged back
into the default branch).

Signed-off-by: Pranshu Srivastava <[email protected]>
@rexagod rexagod force-pushed the automate-release branch 2 times, most recently from 464006f to ddd19fd Compare February 21, 2024 08:21
@dashpole
Copy link

/assign @dgrisonnet
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 22, 2024
@rexagod rexagod force-pushed the automate-release branch 3 times, most recently from e9eb62a to 9923a5f Compare March 4, 2024 09:42
rexagod
rexagod commented Mar 4, 2024
View reviewed changes
scripts/generate-release-notes.sh

# Replace the first line of the CHANGELOG.md file with the expected metadata.
# NOTE: This is done to ensure the latest release header is consistent, and will replace the manual placeholder.
$SED -i "1s/.*/## v$latest_tag / $(date +'%Y-%m-%d')/" CHANGELOG.md
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also modified the PR template to reflect this change: https://github.com/kubernetes/kube-state-metrics/pull/2325/files#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35.

@rexagod
chore: automate release workflow
26e02a6 
Signed-off-by: Pranshu Srivastava <[email protected]>
mrueg
mrueg reviewed Mar 5, 2024
View reviewed changes
scripts/update-compatibility-matrix.sh
@@ -0,0 +1,53 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this a bit more programmatically instead of search and replacing values?
We could use a README.md.tmpl template file + a config and https://github.com/hairyhenderson/gomplate or a similar tool.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrueg mrueg mrueg left review comments

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rexagod @k8s-ci-robot @dashpole @mrueg @dgrisonnet