-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate stable metrics via static analysis, which adapts codes from k/k stable metrics framework #2294
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CatherineF-dev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
685ca7b
to
85cd4e1
Compare
7958e99
to
a9fd176
Compare
type: Counter | ||
stabilityLevel: STABLE | ||
labels: | ||
- container2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use container2 to let stability test fail. So it proves this CI job is working
a9fd176
to
36ce101
Compare
cc @mrueg, I added static analysis example code in this PR. |
36ce101
to
83b3e1d
Compare
60e951f
to
b3fa244
Compare
Add ci job for validating stable metrics
b3fa244
to
57c5811
Compare
/assign @rexagod |
Ping~ |
Ah! I missed this, thank you for all the great work here! I'll review this ASAP! Sorry for the delay here! :/ |
Ping~ |
1 similar comment
Ping~ |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it: https://github.com/kubernetes/kube-state-metrics/blob/cee19c38d054a0dac4891d98c43d85949b5498b9/docs/design/validate-stable-metrics.md
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality) N/A
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1833