-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lua resty.balancer module to 0.05 #11123
base: main
Are you sure you want to change the base?
Conversation
Hi @zengyuxing007. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions
/assign @strongjz |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, zengyuxing007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
question: is this a problem on ingress v1.10? We are using nginx v1.25 and I didn't saw an update there |
This is an issue with the resty.balancer module under openresty, and it is not related to the nginx version. This means it should also exist in v1.10 (nginx v1.25). |
https://github.com/kubernetes/ingress-nginx/blob/main/images/nginx-1.25/rootfs/build.sh#L66 /approve cancel Please check other images build that may be using, in this case, on NGINX v1.25 base image that we use for ingress-nginx it is already using the latest commit |
This commit is the same as the one in v0.05. |
This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach |
The This bot removes
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /remove-lifecycle frozen |
Lua resty.balancer module version 0.04 have a known risk that insufficient memory can lead to a crash.
We have encountered this issue in our production environment. (#11125)
ref PR:openresty/lua-resty-balancer@a7a8b62