Scope secret informers per namespace #737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
|
@lubronzhan Could I ask you to take a look at this PR to give an initial go/no-go on whether you think this is something we want to fix? |
|
Any maintainers able to take a look at this PR? |
|
@lubronzhan can you help with this optimisation PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When trying to set up the cloud provider with stricter permissions (not requiring get/list/watch for secrets across all namespaces), I realised that the way that the vSphere provider currently retrieves secrets for credentials requires these wide permissions.
To make the RBAC surface smaller, this PR updates the way we watch secrets to only watch the required namespaces for the secrets from the configuration.
This should be backwards compatible as existing users require get/list/watch on secrets across all namespaces currently.
Future configurations will now be able to specify secret get/list/watch for only the namespaces they need, eg the one containing their credentials for vCenter.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
I have manually tested this but have not updated any unit tests as I wasn't sure where to go for that, any pointers to appropriate tests to update would be appreciated.
Release note: