L4 ILB - skip nodes from the non default network if multi subnet is t… #679
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-triage
k8s-ci-robot
added
the
size/L
|
/assign @cezarygerard |
mmamczur
force-pushed
the
multi-subnet
branch
3 times, most recently
from
e2f6c4c
to
c445469
Compare
k8s-ci-robot
added
size/M
|
/assign @code-elinka |
| @@ -254,6 +256,37 @@ func (g *Cloud) ensureInternalLoadBalancer(clusterName, clusterID string, svc *v | |||
| return status, nil | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
can you add a comment why it is needed
There was a problem hiding this comment.
Oh nvm, I see the comment in the usage
|
/approve |
| } | ||
| if !hasInstanceForNode(instances, nodes[2]) { | ||
| t.Errorf("expected n3 to be in instances but it contained %+v", instanceURLs) | ||
| } |
There was a problem hiding this comment.
check also
if hasInstanceForNode(instances, nodes[3]) {
t.Errorf("unexpected n4 in instances ...
}
There was a problem hiding this comment.
modified. there was a size check as well so it sort of checked it before
|
lgtm overall, one comment on unit test |
k8s-ci-robot
added
size/L
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cezarygerard, code-elinka, mmamczur The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign cheftako |
…urned on.
This will just skip nodes that are not on the default network when creating the instance group.