Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Status to NodeFeature CRD #1664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Status to NodeFeature CRD #1664

wants to merge 1 commit into from
+140 −13

Conversation

ozhuraki
Copy link
Contributor

Closes #1071

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ozhuraki. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ozhuraki
Once this PR has been reviewed and has the lgtm label, please assign marquiz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 16, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 16, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 078619c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/662bae3c9528d60009aee483
😎 Deploy Preview https://deploy-preview-1664--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

TessaIO
TessaIO reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@TessaIO TessaIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @ozhuraki. I actually think that we can store other useful information in the worker NFR status, rather than only updated at, like number of features/labels discovered, number of sources that had failures when doing discovery. I don't have concrete use cases here but this is my opinion for now.

pkg/nfd-worker/nfd-worker.go Outdated Show resolved Hide resolved
@ozhuraki
Copy link
Contributor Author

@TessaIO @PiotrProkop

Thanks for the input. Updated, please take a look.

PiotrProkop
PiotrProkop reviewed Apr 18, 2024
View reviewed changes
api/nfd/v1alpha1/types.go Outdated Show resolved Hide resolved
api/nfd/v1alpha1/types.go Outdated Show resolved Hide resolved
api/nfd/v1alpha1/types.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2024
@ozhuraki
Copy link
Contributor Author

@PiotrProkop

Thanks for the review, updated, please take a look.

PiotrProkop
PiotrProkop reviewed Apr 19, 2024
View reviewed changes
pkg/nfd-worker/nfd-worker.go Outdated Show resolved Hide resolved
api/nfd/v1alpha1/types.go Outdated Show resolved Hide resolved
api/nfd/v1alpha1/types.go Outdated Show resolved Hide resolved
@ozhuraki
Copy link
Contributor Author

@PiotrProkop
Thanks, updated.

@TessaIO
Copy link
Contributor

TessaIO commented Apr 22, 2024 •
edited

@ozhuraki Are you planning to add some e2e tests for this feature? I think they're important in this use case.

@ozhuraki
Copy link
Contributor Author

@TessaIO
OK, I will try to add e2e test

@ozhuraki
Copy link
Contributor Author

@TessaIO

Thanks, added e2e tests, please take a look.

ArangoGutierrez
ArangoGutierrez requested changes Apr 25, 2024
View reviewed changes
test/e2e/node_feature_discovery_test.go Outdated Show resolved Hide resolved
test/e2e/node_feature_discovery_test.go Outdated Show resolved Hide resolved
test/e2e/node_feature_discovery_test.go Show resolved Hide resolved
test/e2e/node_feature_discovery_test.go Outdated Show resolved Hide resolved
@ozhuraki
Copy link
Contributor Author

@ArangoGutierrez

Thanks! Updated, please take a look

@ArangoGutierrez
Copy link
Contributor

@ArangoGutierrez

Thanks! Updated, please take a look

@ozhuraki could you rebase, sorry it took me so long, I have been swamped by other stuff

ArangoGutierrez
ArangoGutierrez requested changes May 24, 2024
View reviewed changes
api/nfd/v1alpha1/types.go
@@ -41,6 +41,7 @@ type NodeFeature struct {
metav1.ObjectMeta `json:"metadata,omitempty"`

Spec NodeFeatureSpec `json:"spec"`
Status NodeFeatureStatus `json:"status"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's have status as a subresource, similar to NodeFeatureGroup

api/nfd/v1alpha1/types.go
NumberOfFeatures int `json:"numberOfFeatures,omitempty"`
// +optional
// Number of errors during last feature discovery.
NumberOfFeatureErrors int `json:"numberOfFeatureErrors,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sounds more like a metric to me, I don't know what others think, I would not have this here

pkg/nfd-worker/nfd-worker.go
nfdClient *nfdclient.Clientset
stop chan struct{} // channel for signaling stop
featureSources []source.FeatureSource
numberOfFeatureSourceErrors int
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll prefer this to be exposed as a metric, but not in the scope of this PR

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez requested changes

@zvonkok zvonkok Awaiting requested review from zvonkok

@PiotrProkop PiotrProkop Awaiting requested review from PiotrProkop

@TessaIO TessaIO Awaiting requested review from TessaIO

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Status for NodeFeature CRD
5 participants
@ozhuraki @k8s-ci-robot @TessaIO @ArangoGutierrez @PiotrProkop