feat/nfd-master: configure CR restrictions #1592

AhmedThresh · 2024-02-16T14:44:53Z

Resolves #1380
Features implemented:

NodeFeatures Namespace selection by using selectors.
Max number of Taints, Labels, and ERs that can be generated by a single CR.
Enable/Disable overriding labels.
Enable/Disable NodeFeatures labels.

Result of e2e tests:

k8s-ci-robot · 2024-02-16T14:45:02Z

Welcome @AhmedThresh!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-02-16T14:45:03Z

Hi @AhmedThresh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

netlify · 2024-02-16T14:45:08Z

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	`37e9ab7`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66538f5b514cc10008d920e5
😎 Deploy Preview	https://deploy-preview-1592--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AhmedThresh · 2024-02-16T14:46:26Z

/cc @marquiz

AhmedThresh · 2024-02-27T09:40:53Z

ping @marquiz

marquiz

Thanks for the update @AhmedThresh

/ok-to-test

pkg/nfd-master/nfd-master.go

linux-foundation-easycla · 2024-02-28T20:22:31Z

The committers listed above are authorized under a signed CLA.

✅ login: TessaIO (7ed4837, 1ab5675, 37e9ab7)

TessaIO · 2024-03-04T14:10:49Z

ping @marquiz. Any more thoughts on this?

ArangoGutierrez · 2024-03-11T10:05:44Z

/assign @marquiz

pkg/nfd-master/nfd-master.go

AhmedThresh · 2024-05-12T19:21:47Z

@ArangoGutierrez @marquiz Thanks. It Should be good now.
For commits, I will improve them in the new PR that I will open with @TessaIO account

marquiz

Wow, thanks for the update (and thx for working on this in the first place) @TessaIO. Some comments below. We're getting there, one step at a time.

docs/reference/master-configuration-reference.md

pkg/nfd-master/nfd-api-controller.go

pkg/nfd-master/nfd-master.go

TessaIO · 2024-05-15T10:44:56Z

Thanks for the review @marquiz. I will address your comments ASAP.
also, @ArangoGutierrez feel free to take a look at this.

marquiz

A few suggestions/nits on the docs

docs/reference/master-configuration-reference.md

pkg/nfd-master/nfd-master.go

docs/reference/master-configuration-reference.md

marquiz · 2024-05-24T08:22:33Z

/milestone v0.17

Signed-off-by: AhmedGrati <[email protected]>

Signed-off-by: AhmedGrati <[email protected]> Signed-off-by: AhmedThresh <[email protected]> Signed-off-by: AhmedGrati <[email protected]> Signed-off-by: AhmedThresh <[email protected]>

AhmedThresh · 2024-05-26T19:37:34Z

Thanks for the review @marquiz. PTAL!

codecov · 2024-05-26T19:52:17Z

Codecov Report

Attention: Patch coverage is 41.48936% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 39.52%. Comparing base (28079ef) to head (37e9ab7).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1592      +/-   ##
==========================================
- Coverage   39.54%   39.52%   -0.03%     
==========================================
  Files          80       81       +1     
  Lines        7153     7229      +76     
==========================================
+ Hits         2829     2857      +28     
- Misses       4064     4107      +43     
- Partials      260      265       +5

Files	Coverage Δ
pkg/nfd-master/namespace-lister.go	`88.23% <88.23%> (ø)`
pkg/nfd-master/nfd-master.go	`39.34% <48.83%> (-0.10%)`	⬇️
pkg/nfd-master/nfd-api-controller.go	`9.21% <8.82%> (+0.11%)`	⬆️

TessaIO · 2024-05-30T07:31:03Z

ping @marquiz

marquiz · 2024-05-30T10:26:25Z

ping @marquiz

Thanks @TessaIO, will take a look in a bit. I was busy with the v0.16 release, plus other stuff 😇

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2024

k8s-ci-robot requested review from jjacobelli and zvonkok February 16, 2024 14:44

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 16, 2024

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 16, 2024

k8s-ci-robot requested a review from marquiz February 16, 2024 14:46

marquiz reviewed Feb 28, 2024

View reviewed changes

pkg/nfd-master/nfd-master.go Outdated Show resolved Hide resolved

pkg/nfd-master/nfd-master.go Outdated Show resolved Hide resolved

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 28, 2024

AhmedThresh force-pushed the feat-configure-cr-restrictions branch from 46daaca to 6f271b0 Compare February 28, 2024 20:22

AhmedThresh force-pushed the feat-configure-cr-restrictions branch 4 times, most recently from 8d7c72c to 9e4aa7e Compare February 29, 2024 10:44

TessaIO mentioned this pull request Mar 4, 2024

Feat integrate spiffe #1434

Draft

ArangoGutierrez requested a review from marquiz March 11, 2024 10:04

k8s-ci-robot assigned marquiz Mar 11, 2024

ArangoGutierrez requested changes Mar 11, 2024

View reviewed changes

pkg/nfd-master/nfd-master.go Outdated Show resolved Hide resolved

pkg/nfd-master/nfd-master.go Outdated Show resolved Hide resolved

marquiz reviewed May 14, 2024

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024

AhmedThresh force-pushed the feat-configure-cr-restrictions branch 3 times, most recently from f772e7d to 1f1860d Compare May 20, 2024 18:13

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2024

marquiz reviewed May 21, 2024

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2024

k8s-ci-robot added this to the v0.17 milestone May 24, 2024

TessaIO added 2 commits May 26, 2024 13:56

feat/nfd-master: support CR restrictions

7ed4837

Signed-off-by: AhmedGrati <[email protected]>

docs: add CR restrictions to the master configuration reference

1ab5675

Signed-off-by: AhmedGrati <[email protected]>

AhmedThresh force-pushed the feat-configure-cr-restrictions branch from 1f1860d to 4d376b2 Compare May 26, 2024 11:58

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2024

AhmedThresh force-pushed the feat-configure-cr-restrictions branch 8 times, most recently from de1dab8 to 4203744 Compare May 26, 2024 19:34

deploy: add CR restrictions to the helm config

37e9ab7

Signed-off-by: AhmedGrati <[email protected]> Signed-off-by: AhmedThresh <[email protected]> Signed-off-by: AhmedGrati <[email protected]> Signed-off-by: AhmedThresh <[email protected]>

AhmedThresh force-pushed the feat-configure-cr-restrictions branch from 4203744 to 37e9ab7 Compare May 26, 2024 19:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat/nfd-master: configure CR restrictions #1592

feat/nfd-master: configure CR restrictions #1592

AhmedThresh commented Feb 16, 2024 •

edited

k8s-ci-robot commented Feb 16, 2024

k8s-ci-robot commented Feb 16, 2024

netlify bot commented Feb 16, 2024 •

edited

AhmedThresh commented Feb 16, 2024

AhmedThresh commented Feb 27, 2024

marquiz left a comment

linux-foundation-easycla bot commented Feb 28, 2024 •

edited

TessaIO commented Mar 4, 2024

ArangoGutierrez commented Mar 11, 2024

AhmedThresh commented May 12, 2024

marquiz left a comment

TessaIO commented May 15, 2024

marquiz left a comment

marquiz commented May 24, 2024

AhmedThresh commented May 26, 2024

codecov bot commented May 26, 2024

TessaIO commented May 30, 2024

marquiz commented May 30, 2024

feat/nfd-master: configure CR restrictions #1592

Are you sure you want to change the base?

feat/nfd-master: configure CR restrictions #1592

Conversation

AhmedThresh commented Feb 16, 2024 • edited

k8s-ci-robot commented Feb 16, 2024

k8s-ci-robot commented Feb 16, 2024

netlify bot commented Feb 16, 2024 • edited

✅ Deploy Preview for kubernetes-sigs-nfd ready!

AhmedThresh commented Feb 16, 2024

AhmedThresh commented Feb 27, 2024

marquiz left a comment

Choose a reason for hiding this comment

linux-foundation-easycla bot commented Feb 28, 2024 • edited

TessaIO commented Mar 4, 2024

ArangoGutierrez commented Mar 11, 2024

AhmedThresh commented May 12, 2024

marquiz left a comment

Choose a reason for hiding this comment

TessaIO commented May 15, 2024

marquiz left a comment

Choose a reason for hiding this comment

marquiz commented May 24, 2024

AhmedThresh commented May 26, 2024

codecov bot commented May 26, 2024

Codecov Report

TessaIO commented May 30, 2024

marquiz commented May 30, 2024

AhmedThresh commented Feb 16, 2024 •

edited

netlify bot commented Feb 16, 2024 •

edited

linux-foundation-easycla bot commented Feb 28, 2024 •

edited