Add default parameters in the waitForPodsReady configuration #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
tenzen-y
force-pushed
the
add-wait-for-pods-ready-example-config
branch
from
3c3e641
to
9153d0f
Compare
gabesaba
reviewed
May 16, 2024
charts/kueue/values.yaml
Outdated
| @@ -79,7 +79,13 @@ managerConfig: | |||
| burst: 100 | |||
| #pprofBindAddress: :8082 | |||
| #waitForPodsReady: | |||
| # enable: true | |||
| # enable: false | |||
| # timeout: 5m0s | |||
There was a problem hiding this comment.
can this just be 5m, without 0s?
charts/kueue/values.yaml
Outdated
| # blockAdmission: false | ||
| # requeuingStrategy: | ||
| # timestamp: Eviction | ||
| # backoffLimitCount: null // null indicates infinity requeuing |
mimowo
reviewed
May 16, 2024
charts/kueue/values.yaml
Outdated
| # blockAdmission: false | ||
| # requeuingStrategy: | ||
| # timestamp: Eviction | ||
| # backoffLimitCount: null // null indicates infinity requeuing |
There was a problem hiding this comment.
nit: I think // would make the yaml invalid if uncommented? Maybe use #
Signed-off-by: Yuki Iwai <[email protected]>
tenzen-y
force-pushed
the
add-wait-for-pods-ready-example-config
branch
from
9153d0f
to
9718a3b
Compare
|
lgtm |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9b0f3ee3be0e6d8f820c3de85e44fefe183e43bc
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
I added the default parameters to the waitForPodsReady configuration.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?