Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kueuectl] Added list workloads command. #2195

Merged
merged 1 commit into from
May 27, 2024
Merged

[kueuectl] Added list workloads command. #2195

merged 1 commit into from
May 27, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented May 13, 2024 •
edited by alculquicondor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added list workloads command.

Which issue(s) this PR fixes:

Fixes #2135

Special notes for your reviewer:

Does this PR introduce a user-facing change?

CLI: Added list workloads command.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 13, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 13, 2024
@netlify Netlify
Copy link

netlify bot commented May 13, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit b3778e7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6654ddaa24c92400088c8305

@mbobrovskyi
Copy link
Contributor Author

/assign

@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-add-list-workloads-command branch 2 times, most recently from 05c87a1 to 2846e49 Compare May 14, 2024 20:39
@mbobrovskyi
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 14, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-add-list-workloads-command branch from 2846e49 to b778ecb Compare May 14, 2024 21:11
@mbobrovskyi
Copy link
Contributor Author

/ok-to-test

@mbobrovskyi
Copy link
Contributor Author

/test pull-kueue-test-scheduling-perf-main

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 15, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-add-list-workloads-command branch from b778ecb to 7f67e8e Compare May 15, 2024 12:43
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 15, 2024
@mbobrovskyi
Copy link
Contributor Author

/test all

@mbobrovskyi
Copy link
Contributor Author

/assign @trasc

trasc
trasc reviewed May 15, 2024
View reviewed changes
cmd/kueuectl/app/list/helpers.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/helpers.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list_workload_printer.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list_workload_printer.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list_workload_test.go Show resolved Hide resolved
pkg/workload/workload.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list_workload_test.go Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-add-list-workloads-command branch from 7f67e8e to ea51584 Compare May 15, 2024 19:09
@mbobrovskyi
Copy link
Contributor Author

/test all

@mbobrovskyi mbobrovskyi marked this pull request as ready for review May 15, 2024 19:28
@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-add-list-workloads-command branch from d92faad to 9566945 Compare May 20, 2024 18:41
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2024
@k8s-ci-robot k8s-ci-robot requested a review from trasc May 20, 2024 18:41
@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-add-list-workloads-command branch from 9566945 to 2ea8f02 Compare May 20, 2024 18:56
@IrvingMg IrvingMg mentioned this pull request May 21, 2024
Open
@mbobrovskyi
Copy link
Contributor Author

/assign @alculquicondor

@mwielgus mwielgus mentioned this pull request May 22, 2024
Open
@trasc
Copy link
Contributor

trasc commented May 23, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 63daf69883f69ce794202cb41dfc093b3295114d

tenzen-y
tenzen-y reviewed May 24, 2024
View reviewed changes
cmd/kueuectl/app/list/list_workload_printer.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list_workload_printer.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list_workload_printer.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list_workload_test.go
)

func TestWorkloadCmd(t *testing.T) {
testStartTime := time.Now()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that couldn't we introduce the same approach as controllers like this:

But I'm ok with follow-up.

@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-add-list-workloads-command branch from 2ea8f02 to 4eb3c6d Compare May 24, 2024 05:15
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-add-list-workloads-command branch 2 times, most recently from 1b5691d to 2187741 Compare May 27, 2024 05:50
alculquicondor
alculquicondor reviewed May 27, 2024
View reviewed changes
cmd/kueuectl/app/list/list_workload.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list_workload_test.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list_workload_printer.go Outdated Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-add-list-workloads-command branch from 2187741 to b3778e7 Compare May 27, 2024 19:23
alculquicondor
alculquicondor reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b93775db84e0847aa07fa2872f7a0611819cc9d4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3c6a181 into kubernetes-sigs:main May 27, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 27, 2024
@mbobrovskyi mbobrovskyi deleted the feature/kueuectl-add-list-workloads-command branch May 27, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@IrvingMg IrvingMg IrvingMg left review comments

@vladikkuzn vladikkuzn vladikkuzn left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

@mimowo mimowo Awaiting requested review from mimowo

@mwielgus mwielgus Awaiting requested review from mwielgus

@trasc trasc Awaiting requested review from trasc

Assignees

@alculquicondor alculquicondor

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

[kueuectl] Add list Workloads command
7 participants
@mbobrovskyi @k8s-ci-robot @trasc @alculquicondor @IrvingMg @vladikkuzn @tenzen-y