Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use k8s 1.30 API and testing infra. #2005

Merged
merged 4 commits into from
May 29, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Apr 18, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Use Kubernetes 1.30.0 API (k8s.io/[email protected]) and k8s 1.30 in integration and e2e tests.

Which issue(s) this PR fixes:

Fixes #2004

Special notes for your reviewer:

For now, with 0.30.1 for API we can improve the multikueue support for batch/Jobs.
Due to a complex dependency graph, updating other k8s components to 1.30 is challenging:

As of now, combination of controller-runtime, cert-manager and Prometheus.
Updating controller-runtime requires cert-manager (to a not ye release version) which uses a prometheus/client_golang v1.19.1, Version of Prometheus that is not supported by other k8s copmponents.

Does this PR introduce a user-facing change?

Upgrade to Kubernetes v1.30 APIs

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 18, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 18, 2024
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit d4e24cc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66572838d93f4e00089c5f8c
😎 Deploy Preview https://deploy-preview-2005--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trasc trasc mentioned this pull request Apr 18, 2024
3 tasks
go.mod Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 25, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2024
@trasc trasc changed the title Use k8s 1.30 Use k8s 1.30 API and testing infra. May 29, 2024
@trasc trasc marked this pull request as ready for review May 29, 2024 13:10
@k8s-ci-robot k8s-ci-robot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 29, 2024
@trasc
Copy link
Contributor Author

trasc commented May 29, 2024

/cc @alculquicondor @tenzen-y

@alculquicondor
Copy link
Contributor

Which components specifically are the problematic ones?

@trasc
Copy link
Contributor Author

trasc commented May 29, 2024

Which components specifically are the problematic ones?

As of now, combination of controller-runtime, cert-manager and Prometheus.

Updating controller-runtime requires cert-manager (to a not ye release version) which uses a prometheus/client_golang v1.19.1, Version of Prometheus that is not supported by other k8s copmponents.

@alculquicondor
Copy link
Contributor

/release-note-edit

Upgrade to Kubernetes v1.30 APIs

/remove-kind feature
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels May 29, 2024
@alculquicondor
Copy link
Contributor

Thanks, I added the notes about the problematic modules to the PR description.

@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a90af9fa5c1872bab348e90b38089a27e54ca357

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@alculquicondor
Copy link
Contributor

oh, also, can you add test jobs for 1.30?

@k8s-ci-robot k8s-ci-robot merged commit 7a7b391 into kubernetes-sigs:main May 29, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 29, 2024
@trasc trasc deleted the use-k8s-1.30 branch May 29, 2024 14:29
@trasc
Copy link
Contributor Author

trasc commented May 29, 2024

oh, also, can you add test jobs for 1.30?

kubernetes/test-infra#32679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use k8s v1.30.0
4 participants