Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump cni version to v1.4.0 #10698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bump cni version to v1.4.0 #10698

wants to merge 1 commit into from
+5 −1

Conversation

cyclinder
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design

/kind feature

/kind documentation
/kind failing-test
/kind flake

What this PR does / why we need it:

bump cni version to v1.4.0

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[network] bump cni version to v1.4.0

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2023
@yankay
Copy link
Member

yankay commented Dec 8, 2023 •
edited

Thanks @cyclinder

To make Kubespray more production-ready to use, I think the best practice is for the CNI to be bumped to v1.4.0 just after the
kubernetes/kubernetes#122178 be merged, and the new Kube release has been added to the kubespray.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 8, 2023
@yankay yankay removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cyclinder
Once this PR has been reviewed and has the lgtm label, please ask for approval from yankay. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yankay
Copy link
Member

yankay commented Dec 19, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2023
@cyclinder
Copy link
Contributor Author

cyclinder commented Jan 5, 2024 •
edited

kubernetes/kubernetes#122178 has been merged, this PR is ready to merge.

/cc @yankay
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2024
@yankay
Copy link
Member

yankay commented Jan 5, 2024

kubernetes/kubernetes#122178 has been merged, this PR is ready to merge.

/cc @yankay /hold cancel

HI @cyclinder

It will be released at the Kubernetes 1.30.
So, it will be merged when the kubespray supports the Kubernetes 1.30 .

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2024
@cyclinder
Copy link
Contributor Author

It will be released at the Kubernetes 1.30.
So, it will be merged when the kubespray supports the Kubernetes 1.30 .

Got, Thanks for the clarify!

@cyclinder
Copy link
Contributor Author

Hi @yankay, Is it ready to merge？

@yankay
Copy link
Member

yankay commented Feb 2, 2024

Hi @yankay, Is it ready to merge？

HI @cyclinder

It should be merged when the kubespray supports the Kubernetes 1.30 .

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2024
@yankay
Copy link
Member

yankay commented May 6, 2024

pending #11109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

Assignees

@yankay yankay

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cyclinder @yankay @k8s-ci-robot @k8s-triage-robot