Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 🌱 Introduce spec.ClusterName for ProviderServiceAccount #2623

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhanggbj
Copy link
Contributor

What this PR does / why we need it:
Introduce spec.ClusterName for ProviderServiceAccount, also add validation webhook for it.
Please find more details in the issue #2284

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2284

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 17, 2024
@zhanggbj zhanggbj force-pushed the add_clustername branch 3 times, most recently from 72c774d to d13d662 Compare January 17, 2024 09:54
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: Patch coverage is 55.38462% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 64.53%. Comparing base (3559ab2) to head (649cbd1).
Report is 498 commits behind head on main.

Files Patch % Lines
internal/webhooks/providerserviceaccount.go 63.15% 10 Missing and 4 partials ⚠️
controllers/serviceaccount_controller.go 50.00% 9 Missing and 3 partials ⚠️
internal/test/helpers/envtest.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
+ Coverage   64.46%   64.53%   +0.07%     
==========================================
  Files         118      119       +1     
  Lines        8580     8634      +54     
==========================================
+ Hits         5531     5572      +41     
- Misses       2612     2622      +10     
- Partials      437      440       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Introduce spec.ClusterName for ProviderServiceAccount, also add
validation webhook for it.

Signed-off-by: Gong Zhang <[email protected]>
@zhanggbj zhanggbj changed the title [WIP] 🌱 Introduce spec.ClusterName for ProviderServiceAccount 🌱 Introduce spec.ClusterName for ProviderServiceAccount Jan 18, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2024
@zhanggbj zhanggbj changed the title 🌱 Introduce spec.ClusterName for ProviderServiceAccount [WIP] 🌱 Introduce spec.ClusterName for ProviderServiceAccount Jan 18, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2024
@k8s-ci-robot
Copy link
Contributor

@zhanggbj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-e2e-blocking-main 649cbd1 link true /test pull-cluster-api-provider-vsphere-e2e-blocking-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Cluster reference field in the ProviderServiceAccount API type
2 participants