Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Change AdoptPorts to not be Machine dependent #2071

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented May 8, 2024

What this PR does / why we need it:

Allow to re-use AdoptPorts function without the Machine API.
This is useful work for the OpenStackServer effort where we need this
function but don't want to rely on the MachineResources.

Allow to re-use `AdoptPorts` function without the Machine API.
This is useful work for the `OpenStackServer` effort where we need this
function but don't want to rely on the MachineResources.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jichenjc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2024
@k8s-ci-robot k8s-ci-robot requested review from dulek and mdbooth May 8, 2024 19:09
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 8, 2024
@EmilienM
Copy link
Contributor Author

EmilienM commented May 8, 2024

This will fail in tests, I'm not sure why yet.

Copy link

netlify bot commented May 8, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 3979e1e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/663bcdf6a4b866000832c0c1
😎 Deploy Preview https://deploy-preview-2071--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM EmilienM changed the title Change AdoptPorts to not be Machine dependent 🌱 Change AdoptPorts to not be Machine dependent May 8, 2024
@k8s-ci-robot
Copy link
Contributor

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-test 3979e1e link true /test pull-cluster-api-provider-openstack-test
pull-cluster-api-provider-openstack-e2e-test 3979e1e link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

None yet

2 participants