🌱 Build node images with cloud build #1746

lentzi90 · 2023-11-10T13:40:20Z

What this PR does / why we need it:

Add cloud build configuration for building node images.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1502

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

squashed commits
if necessary:
- includes documentation
- adds unit tests

/hold

netlify · 2023-11-10T13:40:26Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	`979fc28`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65bca66dcd23360008846cf4
😎 Deploy Preview	https://deploy-preview-1746--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot · 2023-11-10T13:40:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lentzi90 · 2023-11-10T13:52:55Z

I did not manage to figure out how the builds are triggered. Any clue where to add a trigger for this? Or at least how to test it once?
@mdbooth @tormath1

tormath1 · 2023-11-10T14:46:12Z

@lentzi90 it has to be tested with a Google Cloud account: you need to enable cloudbuild and to add the repo / branch where the cloudbuild.yaml is present. (https://cloud.google.com/build/docs/overview)
I tested with my personal account back in the days - since you are a CAPO maintainer, you might have access to the Cluster API GCP account (or at least to some part) ?

lentzi90 · 2023-11-10T19:01:54Z

Yeah I can see the cloud console, I can see the existing builds, but they are not triggered from "triggers" in cloud build and it seems I don't have privileges to add any. My guess is that it is all managed externally somehow. Perhaps they are triggered from test-infra?

Co-authored-by: Mathieu Tortuyaux <[email protected]> Co-authored-by: Matthew Booth <[email protected]> Signed-off-by: Lennart Jern <[email protected]>

osimages/cloudbuild-osimages.yaml

.github/workflows/osimages.yaml

lentzi90 · 2024-01-26T11:43:47Z

Any clue why make -C osimages -j2 ACCELERATOR=kvm \ osimage-flatcar-1.27.2 \ osimage-flatcar-1.28.2 \ osimage-ubuntu-2204-1.28.2 \ osimage-ubuntu-2204-1.27.2 becomes

 docker run --rm --privileged \
	--network=host \
	-v "/home/runner/work/cluster-api-provider-openstack/cluster-api-provider-openstack/_artifacts/osimages:/output" \
	-e PACKER_LOG=1 \
	-e PACKER_FLAGS=" \
	    --var 'boot_wait=300s' \
	    --var 'accelerator=kvm' \
	    --var 'kubernetes_semver=v1.27.2.o' \
	    --var 'kubernetes_series=v1.27.o' \

(note the .o in v1.27.2.0)
@tormath1

tormath1 · 2024-01-26T13:32:35Z

Any clue why make -C osimages -j2 ACCELERATOR=kvm \ osimage-flatcar-1.27.2 \ osimage-flatcar-1.28.2 \ osimage-ubuntu-2204-1.28.2 \ osimage-ubuntu-2204-1.27.2 becomes
 docker run --rm --privileged \
	--network=host \
	-v "/home/runner/work/cluster-api-provider-openstack/cluster-api-provider-openstack/_artifacts/osimages:/output" \
	-e PACKER_LOG=1 \
	-e PACKER_FLAGS=" \
	    --var 'boot_wait=300s' \
	    --var 'accelerator=kvm' \
	    --var 'kubernetes_semver=v1.27.2.o' \
	    --var 'kubernetes_series=v1.27.o' \
(note the .o in v1.27.2.0) @tormath1

@lentzi90 very strange. It seems to come from the \ - while I'm checking this you can try to use a single line:

make -j2 ACCELERATOR=none osimage-flatcar-1.27.2 osimage-flatcar-1.28.2 osimage-ubuntu-2204-1.28.2 osimage-ubuntu-2204-1.27.2

tormath1 · 2024-01-26T14:45:55Z

osimages/Makefile

+ docker run --rm $(privileged) \
+ --network=host \
+ -v "$(OSIMAGE_DIR):/output" \
+ -e PACKER_LOG=1 \


NOTE: Now it seems to work, we can remove this line that generates tones of logs.

lentzi90 · 2024-01-29T11:51:42Z

From what I can see, it managed to build both flatcar images, but then it timed out for ubuntu.
https://github.com/Nordix/cluster-api-provider-openstack/actions/runs/7693606423/job/20962692694#step:6:2425

tormath1 · 2024-01-30T09:08:03Z

From what I can see, it managed to build both flatcar images, but then it timed out for ubuntu. https://github.com/Nordix/cluster-api-provider-openstack/actions/runs/7693606423/job/20962692694#step:6:2425

@lentzi90 commands over VNC... We already faced this: https://kubernetes.slack.com/archives/CFKJB65G9/p1679317697144409?thread_ts=1679302801.869119&cid=CFKJB65G9
I suggested back in the days to use 20s for Ubuntu before typing commands 🤷

lentzi90 · 2024-01-31T14:09:56Z

I suggested back in the days to use 20s for Ubuntu before typing commands 🤷

Where/how would I change this?

tormath1 · 2024-01-31T15:04:32Z

osimages/Makefile

+ --network=host \
+ -v "$(OSIMAGE_DIR):/output" \
+ -e PACKER_FLAGS=" \
+ --var 'boot_wait=300s' \


@lentzi90 #1746 (comment) you can change the value here.

k8s-triage-robot · 2024-05-02T08:53:45Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mdbooth · 2024-05-02T15:17:30Z

@lentzi90 @tormath1 this has fallen through the cracks. Do we want to resurrect this?

lentzi90 · 2024-05-03T05:35:45Z

I guess we do. My last attempt was to use GitHub actions. It looked promising at first, but kept failing from running out of disk space 🙁
The standard runners have only 14 GB disks. I guess that is just not enough.

mdbooth · 2024-05-03T12:43:28Z

Incidentally, I think I saw one of the infra folks mention that they didn't want anybody publishing container images from the staging repo because we get charged egress for it (but registry.k8s is ok). I'm guessing publishing OS images from our staging bucket would be even worse. The way we use them in our CI is presumably fine because they never leave GCP, but I suspect we should not routinely direct users to them for fear of blowing the credit card.

@dims Do I have that right?

k8s-triage-robot · 2024-06-02T13:18:41Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

lentzi90 · 2024-06-03T04:30:34Z

/remove-lifecycle rotten

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2023

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 10, 2023

k8s-ci-robot requested review from dulek and tobiasgiese November 10, 2023 13:40

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 10, 2023

Build node images with cloud build

427620d

Co-authored-by: Mathieu Tortuyaux <[email protected]> Co-authored-by: Matthew Booth <[email protected]> Signed-off-by: Lennart Jern <[email protected]>

lentzi90 force-pushed the lentzi90/osimage-cloudbuild branch from 6927094 to 77c10e9 Compare January 24, 2024 13:39

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2024

lentzi90 force-pushed the lentzi90/osimage-cloudbuild branch 2 times, most recently from 9b9c117 to 08e7227 Compare January 24, 2024 13:45

tormath1 reviewed Jan 24, 2024

View reviewed changes

osimages/cloudbuild-osimages.yaml Show resolved Hide resolved

lentzi90 force-pushed the lentzi90/osimage-cloudbuild branch 2 times, most recently from 2ee34f2 to 21a7a2f Compare January 24, 2024 14:26

tormath1 reviewed Jan 24, 2024

View reviewed changes

.github/workflows/osimages.yaml Outdated Show resolved Hide resolved

lentzi90 force-pushed the lentzi90/osimage-cloudbuild branch 7 times, most recently from 39d7ca8 to d813e41 Compare January 26, 2024 09:05

Add github action

bc6558b

lentzi90 force-pushed the lentzi90/osimage-cloudbuild branch from d813e41 to bc6558b Compare January 26, 2024 14:31

tormath1 reviewed Jan 26, 2024

View reviewed changes

Reduce logging

b5a93f3

tormath1 reviewed Jan 31, 2024

View reviewed changes

lentzi90 added 3 commits January 31, 2024 17:52

Reduce boot_wait

a34dac5

Use newer ubuntu ISO

9fe52f4

Test build only ubuntu v1.28.2

979fc28

lentzi90 force-pushed the lentzi90/osimage-cloudbuild branch from f3b25f6 to 979fc28 Compare February 2, 2024 08:23

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 2, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌱 Build node images with cloud build #1746

🌱 Build node images with cloud build #1746

lentzi90 commented Nov 10, 2023

netlify bot commented Nov 10, 2023 •

edited

k8s-ci-robot commented Nov 10, 2023

lentzi90 commented Nov 10, 2023

tormath1 commented Nov 10, 2023

lentzi90 commented Nov 10, 2023

lentzi90 commented Jan 26, 2024

tormath1 commented Jan 26, 2024

tormath1 Jan 26, 2024

lentzi90 commented Jan 29, 2024 •

edited

tormath1 commented Jan 30, 2024

lentzi90 commented Jan 31, 2024

tormath1 Jan 31, 2024

k8s-triage-robot commented May 2, 2024

mdbooth commented May 2, 2024

lentzi90 commented May 3, 2024

mdbooth commented May 3, 2024

k8s-triage-robot commented Jun 2, 2024

lentzi90 commented Jun 3, 2024

🌱 Build node images with cloud build #1746

Are you sure you want to change the base?

🌱 Build node images with cloud build #1746

Conversation

lentzi90 commented Nov 10, 2023

netlify bot commented Nov 10, 2023 • edited

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

k8s-ci-robot commented Nov 10, 2023

lentzi90 commented Nov 10, 2023

tormath1 commented Nov 10, 2023

lentzi90 commented Nov 10, 2023

lentzi90 commented Jan 26, 2024

tormath1 commented Jan 26, 2024

tormath1 Jan 26, 2024

Choose a reason for hiding this comment

lentzi90 commented Jan 29, 2024 • edited

tormath1 commented Jan 30, 2024

lentzi90 commented Jan 31, 2024

tormath1 Jan 31, 2024

Choose a reason for hiding this comment

k8s-triage-robot commented May 2, 2024

mdbooth commented May 2, 2024

lentzi90 commented May 3, 2024

mdbooth commented May 3, 2024

k8s-triage-robot commented Jun 2, 2024

lentzi90 commented Jun 3, 2024

netlify bot commented Nov 10, 2023 •

edited

lentzi90 commented Jan 29, 2024 •

edited