-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate AzureClusterIdentity spec.resourceID #4831
deprecate AzureClusterIdentity spec.resourceID #4831
Conversation
/test pull-cluster-api-provider-azure-e2e-optional |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4831 +/- ##
=======================================
Coverage 62.00% 62.01%
=======================================
Files 201 201
Lines 16857 16860 +3
=======================================
+ Hits 10453 10455 +2
- Misses 5620 5622 +2
+ Partials 784 783 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: e17d9b7cd8eff95b79aec0aa9229bbc5b7b0be36
|
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file has a few more instances of this in this file https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4864/files#diff-431747f26534a944aee4c791a094640d69bf911f6d99ae3866fdc220396749cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I opted to keep the webhook check that enforces resourceID
is not specified for non-UserAssignedMSI types since it still seems to help prevent users from setting something that they might expect to make a difference that actually doesn't. So the references to resourceID
in those tests still uphold that check, but I could be convinced to remove everything about resourceID
that doesn't break the API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me!
could you update the doc in the book too? https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4864/files#diff-bd0320cd4ed987841ad875c875e7019896578476c72a8ec8de7ecd458647f35f |
/lgtm |
|
@jsturtevant I tried listing you as a co-author on the doc change but the CLA bot doesn't seem to like that? I made sure to use the same name and email you had on #4864. Do you mind if I drop that from the commit for now? I can try again after I squash. |
NP, something changed with the CLA bot recently and it doesn't like co-authors any more 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: e89b18fa80e17836ab549dfb104a177e87f1ddb3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
503f308
to
1b5ac25
Compare
squashed! |
/retest |
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The
spec.resourceID
field is no longer used in any meaningful way, I think since we eliminated our use of AAD Pod Identity. This change removes the requirement that this field be specified for UserAssignedMSI AzureClusterIdentities and marks the field deprecated to at least make the linter hold us accountable if we ever start to reference it again.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: