use MachinePoolStatusFailure on machinePool

[bravebeaver]

What type of PR is this?
/kind bug

change type of FailureReason on AzureMachinePoolStatus

What this PR does / why we need it:

• set failure reason with MachinePoolStatusFailure type

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3825

Special notes for your reviewer:

Change types on AzureMachinePoolStatus type on the API, which might have external impact.

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: nawazkh / name: Nawaz Hussain K (b3bc34e, 5a56f8e, 91b5c71, 6ea6004, be3317c)
• ✅ login: nojnhuh / name: Jon Huhn (18df86d, 4287ccc, 01b2b7a, 42abc56, 49c7cdc, 7cad3d2)
• ✅ login: bravebeaver / name: beilei (ef743f0, d88b086, 5caba45, 137e8dd, 367114c, 322642f)
• ✅ login: dependabot[bot] (799d715, bf4629e, 7017595, 646b1b6, 05e3e33, 5b1e1f1, 22e902b, 24c3984, 4acc246, cdecc91, 73c1214, f55eff7, ede730a, f5ecb8f)
• ✅ login: willie-yao / name: Willie Yao (3c4b347, 151ca3b)
• ✅ login: mboersma / name: Matt Boersma (eb39667, 756a76e, 42f66a8, b1254f8, 4f11980)
• ✅ login: Jont828 / name: Jonathan Tong (393baca)
• ✅ login: dtzar / name: David Tesar (1a758d9, fd47a1c, ce94184)
• ✅ login: jackfrancis / name: Jack Francis (5445b8b)

[k8s-ci-robot]

Welcome @bravebeaver!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @bravebeaver. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nojnhuh]

/assign @Jont828

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jont828. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[willie-yao]

/ok-to-test

[Jont828]

Looks good so far - just a comment and I think you got a test failure.

[k8s-ci-robot]

@bravebeaver: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-apidiff	322642f	link	false	/test pull-cluster-api-provider-azure-apidiff
pull-cluster-api-provider-azure-test	322642f	link	true	/test pull-cluster-api-provider-azure-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dtzar]

@bravebeaver - I think you just need to fix the e2e test(s) and then you should be good