Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Calico 3.27 and add Windows to Calico helm installer #4435

Closed

Conversation

jsturtevant
Copy link
Contributor

@jsturtevant jsturtevant commented Jan 5, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Upgrades to Calico 3.27.0 which has Windows HPC support. This adds the require fields and removes unused manifests.

Note that ClusterResourceSets are still needed for kube-proxy. Now that CAAPH is further along we might be able to create a Windows kube-proxy helm chart that would remove some more CRS's.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

https://docs.tigera.io/calico/latest/getting-started/kubernetes/windows-calico/operator#operator-installation

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Upgrade Calico addon to 1.27

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sonasingh46 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ce44f1) 61.95% compared to head (16a6b26) 61.95%.
Report is 92 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4435   +/-   ##
=======================================
  Coverage   61.95%   61.95%           
=======================================
  Files         188      188           
  Lines       18768    18768           
=======================================
  Hits        11628    11628           
  Misses       6502     6502           
  Partials      638      638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsturtevant
Copy link
Contributor Author

The pull jobs don't seem to have run at all.
/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2024
@jsturtevant
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2024
@jsturtevant
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2024
@jsturtevant
Copy link
Contributor Author

/retest

@jsturtevant jsturtevant changed the title Upgrade to Calico 1.27 and add Windows to Calico helm installer Upgrade to Calico 3.27 and add Windows to Calico helm installer Jan 11, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@jsturtevant: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-conformance 16a6b26 link false /test pull-cluster-api-provider-azure-conformance
pull-cluster-api-provider-azure-apiversion-upgrade 16a6b26 link false /test pull-cluster-api-provider-azure-apiversion-upgrade
pull-cluster-api-provider-azure-capi-e2e 16a6b26 link false /test pull-cluster-api-provider-azure-capi-e2e
pull-cluster-api-provider-azure-conformance-with-ci-artifacts 16a6b26 link false /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
pull-cluster-api-provider-azure-windows-with-ci-artifacts 16a6b26 link false /test pull-cluster-api-provider-azure-windows-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-custom-builds 16a6b26 link false /test pull-cluster-api-provider-azure-conformance-custom-builds
pull-cluster-api-provider-azure-windows-custom-builds 16a6b26 link false /test pull-cluster-api-provider-azure-windows-custom-builds
pull-cluster-api-provider-azure-ci-entrypoint 16a6b26 link true /test pull-cluster-api-provider-azure-ci-entrypoint
pull-cluster-api-provider-azure-e2e 16a6b26 link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-e2e-aks 16a6b26 link true /test pull-cluster-api-provider-azure-e2e-aks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mboersma mboersma added this to the v1.14 milestone Feb 5, 2024
@nojnhuh nojnhuh removed this from the v1.14 milestone Feb 29, 2024
@nojnhuh nojnhuh added this to the next milestone Feb 29, 2024
@mboersma mboersma modified the milestones: next, v1.15 Mar 13, 2024
@mboersma mboersma removed this from the v1.15 milestone Apr 25, 2024
@jsturtevant
Copy link
Contributor Author

closing for now until calico has better support
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants