Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of FailureReason for AzureMachinePoolStatus from MachineStatusError to MachinePoolStatusFailure #3825

Open
Jont828 opened this issue Aug 10, 2023 · 8 comments · May be fixed by #4558
Open

Change type of FailureReason for AzureMachinePoolStatus from MachineStatusError to MachinePoolStatusFailure #3825

Jont828 opened this issue Aug 10, 2023 · 8 comments · May be fixed by #4558
Assignees
@bravebeaver
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@Jont828
Copy link
Contributor

Jont828 commented Aug 10, 2023

/kind bug

[Before submitting an issue, have you checked the Troubleshooting Guide?]

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
In the status field for AzureMachinePool, the failure reason is of type FailureReason *errors.MachineStatusError. However, there is another type defined called errors.MachinePoolStatusFailure that would be a better fit.

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 10, 2023
@Jont828 Jont828 mentioned this issue Aug 10, 2023
Merged
3 tasks
@willie-yao
Copy link
Contributor

@Jont828 would this be a good first issue? It seems like it could be one but I'm not sure if it's more complicated than it seems.
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Aug 17, 2023
@Jont828
Copy link
Contributor Author

Jont828 commented Aug 17, 2023

I think so, it would just involve changing the API type and where it gets called in machinepool.go.

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@Jont828:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

I think so, it would just involve changing the API type and where it gets called in machinepool.go.

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 17, 2023
This was referenced Aug 17, 2023
Closed
Closed
Closed
Closed
@nawazkh
Copy link
Member

nawazkh commented Aug 17, 2023

/assign @Tea4menono

@k8s-ci-robot
Copy link
Contributor

@nawazkh: GitHub didn't allow me to assign the following users: Tea4menono.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Tea4menono

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bravebeaver
Copy link

hi,

it seems to be a straight change as @Jont828 mentioned. i was wondering since the field is on the API, there might be some client replying on the failure reason type (🤞not)?

could you please assign this one to me?

@bravebeaver
Copy link

/assign

@Jont828
Copy link
Contributor Author

Jont828 commented Jan 26, 2024

What do you mean by client replying on the failure reason type?

@jackfrancis jackfrancis linked a pull request Feb 13, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bravebeaver bravebeaver

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
CAPZ Planning
Status: No status
Milestone
No milestone
5 participants
@Jont828 @k8s-ci-robot @nawazkh @bravebeaver @willie-yao