Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 [PROPOSAL] Move nrb to maintainer #4981

Merged
merged 1 commit into from
May 28, 2024

Conversation

richardcase
Copy link
Member

What type of PR is this?

/kind support

What this PR does / why we need it:

I propose that @nrb be moved from reviewer to maintainer. Nolan has shown great commitment to the project and meets the requirements for maintainership IMHO.

Lazily consensus until Friday 24th May.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Make @nrb a maintainer 

/cc @dlipovetsky @Ankitasw @vincepri

Signed-off-by: Richard Case <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/support Categorizes issue or PR as a support question. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2024
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-test

@Ankitasw
Copy link
Member

+1 from my side 馃憤 thanks for all the great work @nrb

@vincepri
Copy link
Member

+1 from my side as well

@richardcase
Copy link
Member Author

Enough time has passed. Thank @nrb for stepping up to be a maintainer.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

@richardcase: you cannot LGTM your own PR.

In response to this:

Enough time has passed. Thank @nrb for stepping up to be a maintainer.

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@richardcase
Copy link
Member Author

@Ankitasw @dlipovetsky @vincepri @damdo - could you lgtm this when you get time?

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @nrb !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit cc606cf into kubernetes-sigs:main May 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants