Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ SubnetSchema support #4971

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

krasoffski
Copy link

@krasoffski krasoffski commented May 7, 2024

What type of PR is this?
This PR adds functionality related to Subnet schema type, more details can be found in original issue #4784.

Add one of the following kinds:
/kind feature

What this PR does / why we need it:
As I mentioned above, this PR adds ability to configure preferred way for subnets division with priority to private as original behavior by default or public via PreferPublic.
For existing users nothing is changed because original behavior is not changed and set as default. But new parameter PreferPublic allows to use provider in more specific cases like with Google Agones where subnet division to with public subnets priority fits better.

Which issue(s) this PR fixes
Fixes #4784

Special notes for your reviewer:
My first PR to AWS provider =)

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • updates e2e tests

Release note:

New  `AWSCluster.spec.network.vpc.SubnetSchema` parameter  which allows to change preferred way of subnet division to public and private. 

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 7, 2024
Copy link

linux-foundation-easycla bot commented May 7, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: krasoffski / name: Yury Krasouski (4c74e82)

@k8s-ci-robot k8s-ci-robot added needs-priority cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 7, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @krasoffski!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @krasoffski. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 7, 2024
@krasoffski krasoffski changed the title Feature #4784: SubnetSchema support Non-breaking feature: ✨ SubnetSchema support; Issue: 4784 May 7, 2024
@krasoffski krasoffski changed the title Non-breaking feature: ✨ SubnetSchema support; Issue: 4784 ✨ SubnetSchema support; Issue: 4784 May 7, 2024
@krasoffski krasoffski changed the title ✨ SubnetSchema support; Issue: 4784 ✨ SubnetSchema support May 7, 2024
@krasoffski krasoffski force-pushed the feature/support_subnetscheme branch from 2320b77 to 4c74e82 Compare May 7, 2024 14:20
@krasoffski
Copy link
Author

krasoffski commented May 13, 2024

Hi, @dlipovetsky and @richardcase
Despite the fact, PR marked as size/XL the code change is small and simple. Rest of 90% of change is adding new unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subnet division enhacement
2 participants