-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ SubnetSchema support #4971
base: main
Are you sure you want to change the base?
✨ SubnetSchema support #4971
Conversation
|
Welcome @krasoffski! |
Hi @krasoffski. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2320b77
to
4c74e82
Compare
Hi, @dlipovetsky and @richardcase |
What type of PR is this?
This PR adds functionality related to Subnet schema type, more details can be found in original issue #4784.
Add one of the following kinds:
/kind feature
What this PR does / why we need it:
As I mentioned above, this PR adds ability to configure preferred way for subnets division with priority to private as original behavior by default or public via
PreferPublic
.For existing users nothing is changed because original behavior is not changed and set as default. But new parameter
PreferPublic
allows to use provider in more specific cases like with Google Agones where subnet division to with public subnets priority fits better.Which issue(s) this PR fixes
Fixes #4784
Special notes for your reviewer:
My first PR to AWS provider =)
Checklist:
Release note: