Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Add documentation for nightly builds #4968

Merged

Conversation

damdo
Copy link
Member

@damdo damdo commented May 6, 2024

What type of PR is this?
/kind documentation

What this PR does / why we need it:
馃摉 Add documentation for nightly builds

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2024
@damdo
Copy link
Member Author

damdo commented May 6, 2024

/assign @nrb

@k8s-ci-robot k8s-ci-robot requested review from Ankitasw and nrb May 6, 2024 07:20
@damdo damdo requested review from richardcase and removed request for nrb and Ankitasw May 6, 2024 07:20
@damdo damdo force-pushed the add-documentation-for-nightly-builds branch from d0b3ecf to f061a84 Compare May 6, 2024 07:21
@damdo damdo force-pushed the add-documentation-for-nightly-builds branch from f061a84 to 927508d Compare May 6, 2024 07:24
@damdo
Copy link
Member Author

damdo commented May 6, 2024

/assign @richardcase @dlipovetsky

Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, proposed a couple small changes.

@damdo damdo added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 7, 2024
@nrb
Copy link
Contributor

nrb commented May 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2024
@damdo
Copy link
Member Author

damdo commented May 20, 2024

/assign @Ankitasw

@Ankitasw
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 39345f3 into kubernetes-sigs:main May 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants