-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 ROSA: Fix issue-4936 delete rosaMachinePool and rosaControlPlane #4953
Conversation
Hi @serngawy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @muraee |
/cc @vincepri |
/area provider/rosa |
/hold |
da55ddf
to
dde9315
Compare
/unhold |
e5cf6c9
to
e456b12
Compare
@nrb would you approve this PR |
/approve |
Thanks! How do we know this work? We need to start working towards having CI gating in place, that might be a full rosa CRUD, that might be something lighter for starters. |
There is e2e and integration test effort is happening, I believe it will be in another PR. |
lgtm pending Daniels open comments |
Signed-off-by: melserngawy <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlipovetsky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@enxebre would you lgtm the PR |
@dlipovetsky Do you have any other comment on the PR ? would you lgtm if not |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix delete rosaControlPlane and rosaMachinePool
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4936
Special notes for your reviewer:
Checklist:
Release note: