🐛 Fix helm chart syntax errors #533
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -45,7 +45,7 @@ spec: | |||
| {{- end }} | |||
| {{- if $.Values.manager }} | |||
| manager: | |||
| {{- if $.Values.manager.featureGates.core }} | |||
| {{- if and $.Values.manager.featureGates $.Values.manager.featureGates.core }} | |||
There was a problem hiding this comment.
Fixes nil pointer exception if manager is defined but not manager.featureGates
| @@ -38,15 +38,15 @@ metadata: | |||
| annotations: | |||
| "helm.sh/hook": "post-install" | |||
| "helm.sh/hook-weight": "2" | |||
| {{- if or $infrastructureVersion $.Values.configSecret.name }} | |||
| {{- if or $infrastructureVersion $.Values.configSecret.name $.Values.manager }} | |||
There was a problem hiding this comment.
This fixes a bug where spec: is not printed when infrastructureVersion .Values.configSecret.name are not specified and Values.manager is.
| spec: | ||
| {{- end }} | ||
| {{- if $infrastructureVersion }} | ||
| version: {{ $infrastructureVersion }} | ||
| {{- end }} | ||
| {{- if $.Values.manager }} | ||
| manager: | ||
| {{- if hasKey $.Values.manager.featureGates $infrastructureName }} | ||
| {{- if and (kindIs "map" $.Values.manager.featureGates) (hasKey $.Values.manager.featureGates $infrastructureName) }} |
There was a problem hiding this comment.
This fixes a type check error if $.Values.manager.featureGates is not specified.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: dd57901978af6ad5b4553b19b357a2d5518616ac
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This PR fixes a few edge cases that cause syntax errors in helm charts.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes part of #532